Skip to content

Commit

Permalink
fix(dependencies): fix peer dependencies (#2528)
Browse files Browse the repository at this point in the history
* Fix (peer) dependencies

* Declare `prop-types` as a dependency of `@nivo/core` (as recommended in their README)
* Declare `react` as a peer dependency of `@nivo/tooltip`
* Update lockfile

Fixes #2401

Signed-off-by: Marvin A. Ruder <[email protected]>

* Use and declare the same `pnpm` version as `ci/codesandbox` uses

Signed-off-by: Marvin A. Ruder <[email protected]>

---------

Signed-off-by: Marvin A. Ruder <[email protected]>
  • Loading branch information
marvinruder authored Mar 6, 2024
1 parent 193a4ce commit 68375a1
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 13 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,5 +90,5 @@
"type": "opencollective",
"url": "https://opencollective.com/nivo"
},
"packageManager": "pnpm@8.3.1"
"packageManager": "pnpm@8.10.2"
}
4 changes: 2 additions & 2 deletions packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
"d3-scale-chromatic": "^3.0.0",
"d3-shape": "^1.3.5",
"d3-time-format": "^3.0.0",
"lodash": "^4.17.21"
"lodash": "^4.17.21",
"prop-types": "^15.7.2"
},
"peerDependencies": {
"prop-types": ">= 15.5.10 < 16.0.0",
"react": ">= 16.14.0 < 19.0.0"
},
"publishConfig": {
Expand Down
3 changes: 3 additions & 0 deletions packages/tooltip/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
"@nivo/core": "workspace:*",
"@react-spring/web": "9.4.5 || ^9.7.2"
},
"peerDependencies": {
"react": ">= 16.14.0 < 19.0.0"
},
"publishConfig": {
"access": "public"
}
Expand Down
23 changes: 13 additions & 10 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 68375a1

Please sign in to comment.