-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix Persian calendar leap year #7456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -117,10 +117,12 @@ | |||
"to-px": "1.0.1", | |||
"topojson-client": "^3.1.0", | |||
"webgl-context": "^2.2.0", | |||
"world-calendars": "^1.0.3" | |||
"world-calendars": "github:archmoj/world-calendars#0faeec8544d289c94845a73fcbb813b9bb423599" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should really move world-calendars
into the Plotly org. Happy to approve these both but it'd really be better if this lived entirely in-house.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexcjohnson Thanks for the note.
I think transferring the repository is possible via the "Danger Zone" section of your world-calendars
repository.
Are there additional changes needed on the npm
side?
Obviously plotly.js uses several external packages some of which are written by internal contributors e.g. colormap
by Ben: https://www.npmjs.com/package/colormap
If transferring a popular repository might be risky; there is also the option of forking and publishing under plotly name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing more needed on the NPM side, world-calendars
is already in the Plotly org on NPM. And IDK about "popular repository", I don't get the impression it gets any noticeable use outside of plotly.js. I'll try to transfer it.
Fixes #7421 in
world-calendars
dependency.Added tests.