dcc redesign: checklist #3453
Merged
dcc redesign: checklist #3453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment checklist component
KoolADE85
force-pushed
the
feature/dcc-refactor-checklist
branch
from
c71a2dc to
8438007
Compare
KoolADE85
force-pushed
the
feature/dcc-refactor-checklist
branch
from
653bea8 to
88391b4
Compare
KoolADE85
requested review from
T4rk1n,
ndrezn,
gvwilson and
emilykl
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
dcc.Checklistanddcc.RadioItemsby extracting common functionality out of the Dropdown component into a reusableOptionsListcomponent.All 3 of these components now use the same code for displaying their lists of options.
Some of the type information in
types.tsis also de-duplicated by extracting common attributes (likeid,setProps) into aBaseComponentPropstype.