fixes issue with append action when unique is used with a string pattern

Author: amwmedia

package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-plop",
-  "version": "0.20.0",
+  "version": "0.21.0",
   "description": "programmatic plopping for fun and profit",
   "main": "lib/index.js",
   "types": "index.d.ts",

src/actions/append.js

@@ -15,7 +15,7 @@ const doAppend = function*(data, cfg, plop, fileData) {
 	// if the appended string should be unique (default),
 	// remove any occurence of it (but only if pattern would match)
 
-	if (cfg.unique !== false && new RegExp(cfg.pattern).test(fileData)) {
+	if (cfg.unique !== false) {
 		// only remove after "pattern", so that we remove not too much accidentally
 		const parts = fileData.split(cfg.pattern);
 		const lastPart = parts[parts.length - 1];

tests/append-mock/plop-templates/list-item.txt

@@ -2,4 +2,6 @@ Don't remove me: Plop
 
 -- APPEND ITEMS HERE --
 
+/* APPEND OTHER ITEMS HERE */
+
 +++++++++++++++++++++++++++++++++++++++

tests/append-mock/plop-templates/list.txt

@@ -53,7 +53,14 @@ module.exports = function (plop) {
 				type: 'append',
 				path: 'src/{{listName}}.txt',
 				pattern: /-- APPEND ITEMS HERE --/gi,
-				templateFile: 'plop-templates/list-item.txt',
+				template: '😻 name: {{name}}1',
+				unique: !allowDuplicates
+			},
+			{
+				type: 'append',
+				path: 'src/{{listName}}.txt',
+				pattern: '/* APPEND OTHER ITEMS HERE */',
+				template: '🔥 name: {{name}}2',
 				unique: !allowDuplicates
 			}
 		]

tests/append-mock/plopfile.js

@@ -21,8 +21,10 @@ test('Check if entry will be appended', co.wrap(function* (t) {
 	const filePath = path.resolve(testSrcPath, 'list1.txt');
 	const content = fs.readFileSync(filePath).toString();
 
-	t.is((content.match(/Marco/g) || []).length, 1);
-	t.is((content.match(/Polo/g) || []).length, 1);
+	t.is((content.match(/Marco1/g) || []).length, 1);
+	t.is((content.match(/Polo1/g) || []).length, 1);
+	t.is((content.match(/Marco2/g) || []).length, 1);
+	t.is((content.match(/Polo2/g) || []).length, 1);
 }));
 
 test('Check if duplicates get filtered', co.wrap(function* (t) {
@@ -34,8 +36,10 @@ test('Check if duplicates get filtered', co.wrap(function* (t) {
 	const filePath = path.resolve(testSrcPath, 'list2.txt');
 	const content = fs.readFileSync(filePath).toString();
 
-	t.is((content.match(/Marco/g) || []).length, 1);
-	t.is((content.match(/Polo/g) || []).length, 1);
+	t.is((content.match(/Marco1/g) || []).length, 1);
+	t.is((content.match(/Polo1/g) || []).length, 1);
+	t.is((content.match(/Marco2/g) || []).length, 1);
+	t.is((content.match(/Polo2/g) || []).length, 1);
 }));
 
 test('Check if duplicates are kept, if allowed', co.wrap(function* (t) {
@@ -46,8 +50,10 @@ test('Check if duplicates are kept, if allowed', co.wrap(function* (t) {
 	const filePath = path.resolve(testSrcPath, 'list3.txt');
 	const content = fs.readFileSync(filePath).toString();
 
-	t.is((content.match(/Marco/g) || []).length, 2);
-	t.is((content.match(/Polo/g) || []).length, 1);
+	t.is((content.match(/Marco1/g) || []).length, 2);
+	t.is((content.match(/Polo1/g) || []).length, 1);
+	t.is((content.match(/Marco2/g) || []).length, 2);
+	t.is((content.match(/Polo2/g) || []).length, 1);
 }));
 
 test('Check if duplicates are only removed below the pattern', co.wrap(function* (t) {
@@ -59,6 +65,11 @@ test('Check if duplicates are only removed below the pattern', co.wrap(function*
 	const filePath = path.resolve(testSrcPath, 'list4.txt');
 	const content = fs.readFileSync(filePath).toString();
 
-	t.is((content.match(/Plop/g) || []).length, 2);
-	t.is((content.match(/Polo/g) || []).length, 1);
+	t.is((content.match(/Plop1/g) || []).length, 1);
+	t.is((content.match(/Polo1/g) || []).length, 1);
+	t.is((content.match(/Plop2/g) || []).length, 1);
+	t.is((content.match(/Polo2/g) || []).length, 1);
+
+	// there's a plop at the top
+	t.is((content.match(/Plop/g) || []).length, 3);
 }));