Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use %[%]sql within Databricks #1048

Merged
merged 10 commits into from
Feb 9, 2025

Conversation

danielsparing
Copy link

@danielsparing danielsparing commented Feb 6, 2025

Describe your changes

Issue number

Closes #1047

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--1048.org.readthedocs.build/en/1048/

@edublancas edublancas added the allow-workflow-edits Allow edits to .github/workflows label Feb 9, 2025
@edublancas edublancas merged commit 7e02910 into ploomber:master Feb 9, 2025
18 checks passed
@edublancas
Copy link

@danielsparing I fixed the CI, I also added a test but it was more difficult than expected since magics are an IPython feature and the IPython console is a singleton and I couldn't figure out an easy way to isolate the test.

I'd appreciate it if you can install the version from the main branch and test it a week or so, if everything works well, I can release it

@danielsparing
Copy link
Author

Thank you!

I tried it and seems to work (on Databricks Serverless v2):

411361455-e38e7eb8-cb45-485a-b64c-abbdff32b7cc

@danielsparing danielsparing deleted the disable-sql-databricks branch February 10, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-workflow-edits Allow edits to .github/workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupysql overrides Databricks %sql magic despite alias
2 participants