Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change opacity of sidebar toggle button #4132

Closed
wants to merge 8 commits into from
Closed

Conversation

MAX-786
Copy link
Contributor

@MAX-786 MAX-786 commented Dec 16, 2022

fixes #4131

In "theme/themes/pastanaga/globals/site.variables" changed variable sidebarToggleButtonNormalOpacity: from 0.05 to 0.3 and when on hover state changed opacity from 0.3 to 0.5 which makes it more noticeable and improves UX.

Demo

Untitled.video.-.Made.with.Clipchamp.5.mp4

@netlify
Copy link

netlify bot commented Dec 16, 2022

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 2443408
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/639ee732d4866200086206c9
😎 Deploy Preview https://deploy-preview-4132--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Dec 16, 2022



Test summary

459 0 20 0


Run details

Project Volto
Status Passed
Commit bf0362a
Started Dec 17, 2022 1:17 PM
Ended Dec 17, 2022 1:30 PM
Duration 13:27 💡
OS Linux Ubuntu -
Browser Chrome 108

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@MAX-786 MAX-786 requested a review from tiberiuichim December 16, 2022 06:14
@tiberiuichim
Copy link
Contributor

Some time ago on a client project we added an animation which flashed the sidebar toggle on entering the page, to draw attention to it. @sneridagh would that be a good idea here?

@MAX-786
Copy link
Contributor Author

MAX-786 commented Dec 16, 2022

@tiberiuichim, I think that part is already implemented like when you refresh the page, sidebar handle will blink for 3 times.
Thanks!

@tiberiuichim
Copy link
Contributor

Right, I forgot that we merged that one :)

@MAX-786
Copy link
Contributor Author

MAX-786 commented Dec 16, 2022

To draw more attention to the sidebar toggle we can add tilting and poping up(little bit) animation to it everytime page loads.

@MAX-786 MAX-786 closed this Dec 18, 2022
@aadarsh-nagrath
Copy link
Member

aadarsh-nagrath commented Sep 23, 2023

Some time ago on a client project we added an animation which flashed the sidebar toggle on entering the page, to draw attention to it. @sneridagh would that be a good idea here?

Blinking does work , but changing its color seems better idea -> like the default grey or blue
Changing opacity >>>
image

@MAX-786
Copy link
Contributor Author

MAX-786 commented Sep 23, 2023

Hi @aadarsh-nagrath, this PR is closed but you can check issue #3910 related to this and the already existing WIP PR #3912 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right side "sidebar handle" button is not noticeable
3 participants