Structural fixes #163
Merged
Structural fixes #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add doormat like footer
Have content container before column1 before column2.
Adjust content columns
thomasmassmann
requested review from
mauritsvanrees,
petschki,
pbauer and
jensens
|
Part of #160 . |
|
this is planned for 5.2 only right? so we need to branch away for 5.1. |
|
Those changes are safe for 5.1.x and 5.2.x (even 5.0.x). |
MrTango
approved these changes
Oct 3, 2018
jensens
approved these changes
Oct 3, 2018
|
@MrTango could you please take a look at the failing 5.2 tests? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the current content column and footer implementation.
The current Footer is build on top of footer portlets. But adding additional portlets to the footer will result in a messy and unstyled footer:
With some XSLT and a little bit of CSS we are able to create a doormat like footer with up to 4 columns (1 portlet: 12 col width 2 portlets: 6 cols, 3 portlets: 4 cols, 4 portlets: 3 cols and more than 4 portlets: 3 cols each), based on the underlying bootstrap grid:
The content columns are currently in the "wrong" order in the HTML: column 1 comes before the main content column, which makes it hard to style for mobile views (portlet columns (sidebars) should come at the very end). Bootstrap gives us the option to move columns around, but the order needs to be changed to be able to have all sidebar columns below the main content on mobile width screens.
If both portlet columns are available, they will be shown next to each-other on small screens, and stacked on top of each-other on smallest screens:
On desktop wide screens, columns will be shown in the classic 3-column layout:
