-
-
Notifications
You must be signed in to change notification settings - Fork 9
Pep 420 native namespace #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
gforcada
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 💯
Though, we don't want to merge it right now, or?
davisagli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we have to start somewhere, right?
I tested by checking this out locally and building the dists with uvx --from build python -m build. The contents of the resulting sdist and wheel look okay.
|
Yes, for me this is fine to merge. I could make a release of this package tomorrow and update dist.plone.org so we can smoke out any remaining problems. |
|
Then, should we start creating PRs right and left, or do we want to do we need some extra double checks? I have time and energy for "same thing on lots of repos", not so much for creative work or following up too much. |
|
I have released If nothing suspicious comes up, the road is free to doing this for all plone packages. |
For plone/Products.CMFPlone#3928
Made with plone/meta#297