Skip to content

Conversation

@mauritsvanrees
Copy link
Member

@mauritsvanrees mauritsvanrees commented Oct 16, 2025

@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Member Author

@jenkins-plone-org please run jobs

Copy link
Member

@gforcada gforcada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯

Though, we don't want to merge it right now, or?

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we have to start somewhere, right?

I tested by checking this out locally and building the dists with uvx --from build python -m build. The contents of the resulting sdist and wheel look okay.

@mauritsvanrees
Copy link
Member Author

Yes, for me this is fine to merge. I could make a release of this package tomorrow and update dist.plone.org so we can smoke out any remaining problems.

@mauritsvanrees mauritsvanrees merged commit 51e5c0d into master Oct 26, 2025
12 checks passed
@mauritsvanrees mauritsvanrees deleted the pep-420-native-namespace branch October 26, 2025 09:26
@gforcada
Copy link
Member

Then, should we start creating PRs right and left, or do we want to do we need some extra double checks?

I have time and energy for "same thing on lots of repos", not so much for creative work or following up too much.

@mauritsvanrees
Copy link
Member Author

I have released plone.protect 6.0.0a2 with native namespaces. This is pinned in coredev 6.2. I have updated https://dist.plone.org/release/6.2-dev/

If nothing suspicious comes up, the road is free to doing this for all plone packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants