-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content type intro and FTI reference #1498
Conversation
✅ Deploy Preview for 6-docs-plone-org ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly MyST syntax changes, and a few style changes.
Co-authored-by: Steve Piercy <[email protected]>
@stevepiercy The changes to use
|
Ah, the path needs to be adjusted, as |
The todos in definitions are also messed up. That might be because of a nested backtick fence from the parent glossary, but should be resolved when conversion is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one stray space, and still wonky todos (see updated comment), and it's good to go.
Yeah, there should be only one glossary. Lists are lists. There is slightly different HTML which can be used for CSS, <dl class="glossary">
versus <dl class="simple myst">
.
Co-authored-by: Jens W. Klein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a 🛌 and ☕ , and noticed a couple more things. What do you think?
@davisagli just a heads up to pull my commit a5647c3 before pushing additional work. |
Co-authored-by: Steve Piercy <[email protected]>
@davisagli I'll let you merge, assuming you might want to get another sprinter to look it over. |
@stevepiercy Jens already reviewed it, so I'll go ahead. |
Beginning of work on #1303
This has an intro adapted from https://github.com/plone/training/blob/main/docs/mastering-plone/dexterity.md (but trying to avoid tutorial-style content)
And a reference for the properties that can be set on an FTI to define a content type, inspired by https://github.com/plone/documentation/blob/6.0/plone.app.dexterity/schema-driven-types.md but mostly written from scratch to make sure we're covering all the properties.