Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable storage #152

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Configurable storage #152

wants to merge 8 commits into from

Conversation

tlotze
Copy link
Member

@tlotze tlotze commented Feb 13, 2025

see #151

possible improvements:

  • ZEO version ist hard-coded independent of Plone version
  • we might want to build a ZEO container based on the plone-zeo container in order to install project code and allow for custom conflict resolution
  • devops/.env_gha should be removed for ZEO and FileStorage. I'd postpone this until the project_classic branch is merged to avoid conflicts.

@tlotze tlotze requested a review from ericof as a code owner February 13, 2025 08:00
@tlotze tlotze requested review from stevepiercy and removed request for ericof February 13, 2025 08:00
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nitpick, and I am OK with the UI parts. Still needs a full technical review from people more familiar with the code. Thank you!

@tlotze tlotze force-pushed the configurable-storage branch from dee4436 to 49132fe Compare February 13, 2025 12:27
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messages and docs are good. Still needs technical review. Thank you!

@tlotze tlotze force-pushed the configurable-storage branch 3 times, most recently from 8893d9b to 02027f4 Compare February 17, 2025 08:12
@tlotze tlotze force-pushed the configurable-storage branch from 02027f4 to 66048d5 Compare February 20, 2025 21:29
@tlotze
Copy link
Member Author

tlotze commented Feb 20, 2025

@davisagli Just to be sure – do you expect me to do anything to this PR before it can be merged?

@davisagli
Copy link
Member

@tlotze No, it's waiting until I have time to review and test it.

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlotze Can we make the name of the cookiecutter variable a bit more specific? Otherwise it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants