-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable storage #152
base: main
Are you sure you want to change the base?
Configurable storage #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nitpick, and I am OK with the UI parts. Still needs a full technical review from people more familiar with the code. Thank you!
dee4436
to
49132fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Messages and docs are good. Still needs technical review. Thank you!
8893d9b
to
02027f4
Compare
State clearly that storage choice is only for deployment and that RelStorage is recommended.
02027f4
to
66048d5
Compare
@davisagli Just to be sure – do you expect me to do anything to this PR before it can be merged? |
@tlotze No, it's waiting until I have time to review and test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tlotze Can we make the name of the cookiecutter variable a bit more specific? Otherwise it looks good to me.
see #151
possible improvements:
plone-zeo
container in order to install project code and allow for custom conflict resolutiondevops/.env_gha
should be removed for ZEO and FileStorage. I'd postpone this until theproject_classic
branch is merged to avoid conflicts.