Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding more attribute to message object #246

Merged
merged 3 commits into from
Sep 6, 2024
Merged

adding more attribute to message object #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05b00fa
adding more attribute to message object
narayana-plivo Aug 22, 2024
5214dba
version update
narayana-plivo Sep 6, 2024
67273f9
Merge branch 'master' into addition-mdr-attribute
narayana-plivo Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# Change Log
## [4.60.3](https://github.com/plivo/plivo-ruby/tree/v4.60.3) (2024-09-06)
**Feature - Adding more attribute on mdr object**
- Added `message_sent_time`, `message_updated_time` and `error-message` on get and list Message API

## [4.60.2](https://github.com/plivo/plivo-ruby/tree/v4.60.2) (2024-09-06)
**Feature - Adding support for brand_name and app_hash in Create,Get and List Session**
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ The Plivo Ruby SDK makes it simpler to integrate communications into your Ruby a
Add this line to your application's Gemfile:

```ruby
gem 'plivo', '>= 4.60.2'
gem 'plivo', '>= 4.60.3'
```

And then execute:
Expand Down
5 changes: 4 additions & 1 deletion lib/plivo/resources/messages.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ def to_s
conversation_id: @conversation_id,
conversation_origin: @conversation_origin,
conversation_expiration_timestamp: @conversation_expiration_timestamp,
log: @log
log: @log,
message_sent_time: @message_sent_time,
message_updated_time: @message_updated_time,
error_message: @error_message
}.to_s
end
end
Expand Down
2 changes: 1 addition & 1 deletion lib/plivo/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Plivo
VERSION = "4.60.2".freeze
VERSION = "4.60.3".freeze
end
5 changes: 4 additions & 1 deletion spec/mocks/messageGetResponse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,8 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
}
100 changes: 80 additions & 20 deletions spec/mocks/messageListResponse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": null,
Expand All @@ -55,7 +58,10 @@
"carrier_fees": "0.001",
"conversation_id": "123",
"conversation_origin": "service",
"conversation_expiration_timestamp": "2023-08-03 23:02:00+05:30"
"conversation_expiration_timestamp": "2023-08-03 23:02:00+05:30",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": null,
Expand All @@ -80,7 +86,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": null,
Expand All @@ -105,7 +114,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": null,
Expand All @@ -130,7 +142,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": null,
Expand All @@ -155,7 +170,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": null,
Expand All @@ -180,7 +198,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": null,
Expand All @@ -205,7 +226,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": "000",
Expand All @@ -230,7 +254,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": null,
Expand All @@ -255,7 +282,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": "000",
Expand All @@ -280,7 +310,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": null,
Expand All @@ -305,7 +338,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": "000",
Expand All @@ -330,7 +366,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": null,
Expand All @@ -355,7 +394,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": "000",
Expand All @@ -380,7 +422,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": null,
Expand All @@ -405,7 +450,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": "000",
Expand All @@ -430,7 +478,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": "000",
Expand All @@ -455,7 +506,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": "000",
Expand All @@ -480,7 +534,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
},
{
"error_code": "000",
Expand All @@ -505,7 +562,10 @@
"carrier_fees": "0.001",
"conversation_id": "",
"conversation_origin": "",
"conversation_expiration_timestamp": ""
"conversation_expiration_timestamp": "",
"message_sent_time": "2024-08-21 18:28:49.244057+05:30",
"message_updated_time": "2024-08-21 18:28:51.94772+05:30",
"error_message": ""
}
]
}
Loading