Merge pull request #317 from plivo/fix-unrent-ppk

MPT-3652 - unrent fix
plivo · Sep 1, 2023 · c65472d · c65472d
2 parents f453d1a + 1164049
commit c65472d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Change Log
 
+## [v4.56.1](https://github.com/plivo/plivo-node/tree/v4.56.1) (2023-09-01)
+**Bug Fix - unrent powerpack number**
+- Fix for Error: invalid powerpack number delete request (400) - Unrent Powerpack Number
+
+
 ## [v4.56.0](https://github.com/plivo/plivo-node/tree/v4.56.0) (2023-08-25)
 **Feature - Added New Param 'carrier_fees', 'carrier_fees_rate', 'destination_network' in Get Message and List Message APIs**
 - Added new params on message get and list response

diff --git a/lib/resources/powerpacks.js b/lib/resources/powerpacks.js
@@ -313,7 +313,7 @@ export class Powerpack extends PlivoResource {
 
     remove_number(number, unrent = false) {
         var params = {};
-        params['unrent'] = unrent.toString();
+        params['unrent'] = unrent;
         let path = 'NumberPool/' + this.number_pool_id + '/Number/' + number + '/';
         let client = this[clientKey];
         return new Promise((resolve, reject) => {
@@ -328,7 +328,7 @@ export class Powerpack extends PlivoResource {
     }
     remove_tollfree(tollfree, unrent = false) {
         var params = {};
-        params['unrent'] = unrent.toString();
+        params['unrent'] = unrent;
         let path = 'NumberPool/' + this.number_pool_id + '/Tollfree/' + tollfree + '/';
         let client = this[clientKey];
         return new Promise((resolve, reject) => {
@@ -483,9 +483,7 @@ export class Powerpack extends PlivoResource {
      */
     delete(unrent_numbers = false) {
         let params = {};
-        if (typeof unrent_numbers === 'boolean') {
-            params.unrent_numbers = unrent_numbers.toString();
-        }
+        params.unrent_numbers = unrent_numbers;
         let path = 'Powerpack/' + this.uuid + '/';
         return super.customexecuteAction(path.toString().trim(), 'DELETE', params);
     }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "plivo",
-  "version": "4.56.0",
+  "version": "4.56.1",
   "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML",
   "homepage": "https://github.com/plivo/plivo-node",
   "files": [