Skip to content

Commit

Permalink
Merge pull request #215 from plivo/invalid_dst
Browse files Browse the repository at this point in the history
handle invalid number response on bulk send sms
  • Loading branch information
huzaif-plivo authored Sep 27, 2021
2 parents 3f079ad + cf55ef5 commit 8c728ca
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## [v4.22.4](https://github.com/plivo/plivo-node/tree/v4.22.4) (2021-09-27)
**Bug Fix**
- Handle invalid destination number API response for send [SMS API](https://www.plivo.com/docs/sms/api/message/send-a-message/).

## [v4.22.3](https://github.com/plivo/plivo-node/tree/v4.22.3) (2021-09-22)
**Bug Fix**
- Fix Typings for `Make call` & `Send SMS` API response.
Expand Down
4 changes: 3 additions & 1 deletion lib/resources/messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ export class MessageResponse {
this.apiId = params.apiId;
this.message = params.message;
this.messageUuid = params.messageUuid;

if (params.invalidNumber != undefined ){
this.invalid_number = params.invalidNumber;
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "plivo",
"version": "4.22.3",
"version": "4.22.4",
"description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML",
"homepage": "https://github.com/plivo/plivo-node",
"files": [
Expand Down
1 change: 1 addition & 0 deletions types/resources/messages.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ export class MessageResponse {
apiId: string;
message: string;
messageUuid: Array<string>;
invalidNumber?: Array<string>;
}
export class MessageGetResponse {
constructor(params: object);
Expand Down

0 comments on commit 8c728ca

Please sign in to comment.