Merge pull request #266 from plivo/endpoint-list-fix

adding limit and offset support endpoint fetch
plivo · Oct 18, 2022 · 84fb9fa · 84fb9fa
2 parents 21f7ac8 + 61c6b8b
commit 84fb9fa
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Change Log
 
+## [v4.34.2](https://github.com/plivo/plivo-go/tree/v4.34.2) (2022-10-17)
+**List Endpoint query param support**
+-  Adding limit and offset to fetch list of endpoints.
+
 ## [v4.34.1](https://github.com/plivo/plivo-go/tree/v4.34.1) (2022-09-28)
 **10DLC campaign creation**
 -  Adding more attributes to campaign creation request.

diff --git a/lib/resources/endpoints.js b/lib/resources/endpoints.js
@@ -180,9 +180,9 @@ export class EndpointInterface extends PlivoResourceInterface {
               });
       });
   }
-
-  list() {
-      let params = {};
+//   * @param {integer} [params.offset] - No of value items by which results should be offset
+//   * @param {integer} [params.limit] - No of value items by which results should be offset
+  list(params = {}) {
       params.isVoiceRequest = 'true';
 
       let client = this[clientKey];

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "plivo",
-  "version": "4.34.1",
+  "version": "4.34.2",
   "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML",
   "homepage": "https://github.com/plivo/plivo-node",
   "files": [