Upgrade dependencies #545
Upgrade dependencies #545
Conversation
WalkthroughThe changes in this update focus on enhancing error handling by replacing Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum
Files selected for processing (40)
- .golangci.yml (5 hunks)
- dtls/client_test.go (1 hunks)
- dtls/server/server.go (2 hunks)
- dtls/server/session.go (2 hunks)
- message/codes/code_string.go (2 hunks)
- message/codes/codes.go (2 hunks)
- message/codes/codes_test.go (1 hunks)
- message/option.go (3 hunks)
- message/options_test.go (2 hunks)
- message/pool/message_test.go (2 hunks)
- message/status/status_test.go (3 hunks)
- mux/router.go (1 hunks)
- mux/router_test.go (1 hunks)
- net/blockwise/blockwise.go (9 hunks)
- net/blockwise/blockwise_test.go (5 hunks)
- net/client/limitParallelRequests/limitParallelRequests_test.go (2 hunks)
- net/connUDP.go (6 hunks)
- net/connUDP_internal_test.go (3 hunks)
- net/conn_test.go (3 hunks)
- net/dtlslistener.go (1 hunks)
- net/observation/handler.go (4 hunks)
- net/tlslistener_test.go (4 hunks)
- pkg/cache/cache_test.go (2 hunks)
- pkg/sync/map.go (1 hunks)
- server.go (2 hunks)
- tcp/client/conn.go (1 hunks)
- tcp/client/session.go (2 hunks)
- tcp/client_test.go (1 hunks)
- tcp/coder/bench_test.go (1 hunks)
- tcp/coder/coder_test.go (1 hunks)
- tcp/server/server.go (2 hunks)
- udp/client/conn.go (2 hunks)
- udp/client/conn_test.go (2 hunks)
- udp/client_test.go (10 hunks)
- udp/coder/bench_test.go (1 hunks)
- udp/coder/coder_test.go (1 hunks)
- udp/server/discover.go (3 hunks)
- udp/server/server.go (4 hunks)
- udp/server/session.go (2 hunks)
- udp/server_test.go (1 hunks)
Additional Context Used
GitHub Check Runs (1)
test1_20 failure (3)
pkg/sync/map.go: [failure] 4-4:
package maps is not in GOROOT (/opt/hostedtoolcache/go/1.20.14/x64/src/maps)
Additional comments not posted (88)
message/status/status_test.go (2)
27-27: The replacement oferrors.Iswithrequire.ErrorIsin test assertions is a good practice. It ensures that the test fails immediately if the condition is not met, making the tests more robust and easier to debug.
36-36: Usingrequire.ErrorIsfor error comparison is consistent with the improvements made in error handling across the project. This change enhances the clarity and reliability of the test cases.tcp/coder/bench_test.go (1)
15-15: Explicitly declaringencas anintimproves code readability by making the type ofencimmediately clear. This is a minor but positive change for maintainability.udp/coder/bench_test.go (1)
15-15: Just like in the TCP coder benchmark test, explicitly declaringencas aninthere enhances code clarity. Consistency in such improvements across similar files is commendable.net/conn_test.go (7)
43-43: Switching fromassert.NoErrortorequire.NoErrorensures that the test halts immediately if an error occurs, which is a best practice for critical error checks in tests.
46-46: Consistently usingrequire.NoErrorfor error handling in test teardown logic is a good practice, ensuring that any errors during cleanup are immediately addressed.
61-61: Applyingrequire.NoErrorwithin the test's goroutine for closing connections enhances the test's reliability by ensuring immediate failure on errors.
68-68: Usingrequire.NoErrorfor error handling after dialing enhances the robustness of the test setup phase.
72-72: Ensuring no error occurs when closing the connection withrequire.NoErroris crucial for clean test teardown. Good use ofrequirefor immediate failure on error.
80-80: Switching torequire.Errorfor expected errors aligns with the goal of making tests fail fast on critical conditions. This change improves the test's clarity and reliability.
83-83: Consistent use ofrequire.NoErrorfor asserting the absence of errors throughout the test cases is a good practice, ensuring that tests fail fast upon encountering an error.message/codes/code_string.go (1)
57-57: Replacingfmt.Errorfwitherrors.Newfor generating errors where no formatting is needed is a good practice. It simplifies the error creation process and slightly improves performance.message/codes/codes_test.go (1)
55-55: Replacingrequire.Truewithrequire.Greaterfor asserting the length of a string provides a more precise and descriptive assertion. This change enhances the clarity and robustness of the test.dtls/server/session.go (2)
22-22: Changing thectxfield type in theSessionstruct fromatomic.Valuetoatomic.Pointer[context.Context]is a significant improvement. It leverages the type safety provided byatomic.Pointer, making the code more robust and type-safe.
93-93: The updatedContext()method to return*s.ctx.Load()directly, thanks to the type safety ofatomic.Pointer[context.Context], simplifies the code and avoids the need for type assertion. This is a cleaner and safer approach.udp/server/discover.go (5)
5-5: Importing theerrorspackage is appropriate for usingerrors.Newfor error creation.
13-13: Renaming theerrorspackage topkgErrorsto avoid conflict with the standard library'serrorspackage is a good practice when both are needed.
47-47: Usingerrors.Newfor creating simple error messages without formatting is a good practice for consistency and performance.
51-51: Replacingfmt.Errorfwitherrors.Newwhen no formatting is needed is a good improvement for error creation.
67-67: Correctly using a package-specific error (pkgErrors.ErrKeyAlreadyExists) ensures that errors are more descriptive and can be handled specifically.udp/server/session.go (2)
21-21: Changing thectxfield type fromatomic.Valuetoatomic.Pointer[context.Context]is a more type-safe approach for storing pointers tocontext.Contextin an atomic way.
104-104: Using*s.ctx.Load()directly without type assertion is now possible due to the specific typeatomic.Pointer[context.Context], enhancing code readability and safety.message/codes/codes.go (1)
120-120: Replacingfmt.Errorfwitherrors.Newfor a simple error message without formatting is a good practice for consistency and performance.pkg/cache/cache_test.go (2)
121-121: Usingrequire.Equaldirectly to compare the expected number of found elements with the actual count is a clear and concise way to assert test conditions.
148-148: Asserting that no elements are found after aLoadAndDeleteAlloperation usingrequire.Equalto check the count is a straightforward way to validate the cache's behavior.net/dtlslistener.go (1)
73-73: Replacingfmt.Errorfwitherrors.Newfor a simple error message without formatting is a good practice for consistency and performance.server.go (2)
6-6: Importing theerrorspackage is appropriate for usingerrors.Newfor error creation.
103-103: Usingerrors.Newfor creating simple error messages without formatting is a good practice for consistency and performance.mux/router_test.go (1)
4-4: Replacing the experimentalgolang.org/x/exp/mapspackage with the stablemapspackage is a good practice for ensuring long-term support and stability.tcp/server/server.go (2)
85-85: Usingerrors.Newfor creating simple error messages without formatting is a good practice for consistency and performance.
138-138: Replacingfmt.Errorfwitherrors.Newfor a simple error message without formatting is a good practice for consistency and performance.dtls/server/server.go (2)
92-92: The change fromfmt.Errorftoerrors.Newfor generating the error message incheckAndSetListenermethod aligns with the PR's objective to standardize error handling.
130-130: The change fromfmt.Errorftoerrors.Newfor generating the error message in theServemethod is consistent with the PR's goal to standardize error handling.net/observation/handler.go (2)
5-5: The addition of theerrorsimport aligns with the PR's objective to standardize error handling.
14-14: Renaming theerrorspackage import topkgErrorsto avoid naming conflicts with the standarderrorspackage is a sensible change.tcp/client/session.go (1)
33-33: The update of thectxfield in theSessionstruct to useatomic.Pointer[context.Context]improves type safety and code clarity, especially in theContext()method where it simplifies context handling by removing the need for type assertion.Also applies to: 141-141
net/client/limitParallelRequests/limitParallelRequests_test.go (2)
30-30: The change fromfmt.Errorftoerrors.Newin thedomethod of themockClientstruct aligns with the PR's objective to standardize error handling.
35-35: The change fromfmt.Errorftoerrors.Newin thedoObservemethod of themockClientstruct is consistent with the PR's goal to standardize error handling.udp/coder/coder_test.go (1)
81-81: The change from an implicit to an explicit variable declaration (var enc int) is a minor stylistic adjustment that improves the clarity of the variable's type. This is generally a good practice for readability, especially in complex functions. However, ensure that such changes align with the project's coding standards and consider if a rationale should be provided for stylistic changes, especially if part of a larger effort to standardize code style.message/pool/message_test.go (2)
358-358: Changing the assertion order torequire.Equal(t, "seek error", err.Error())aligns with best practices by placing the expected value first. This improves the readability of test failures and is a good practice to follow in test assertions.
389-389: The change to userequire.Len(t, data, n)is an improvement, as it leverages a more specific assertion method designed for checking the length of collections. This approach enhances the clarity of test failures by providing more informative error messages.udp/server/server.go (1)
121-121: Usingerrors.Newfor creating simple error messages without formatting is a good practice for consistency and clarity in error handling.message/options_test.go (2)
267-267: Replacingrequire.Equal(t, nil, err)withrequire.NoError(t, err)in test assertions is a good practice for clarity and idiomatic Go code.
291-291: The use ofrequire.NoError(t, err)for error assertions in tests is idiomatic and improves the readability of the test code.net/connUDP_internal_test.go (3)
93-95: The replacement ofassertwithrequirefor error handling in tests is a good practice, ensuring immediate failure upon encountering an error. This change enhances the robustness of the test suite.
211-211: Consider usingrequireinstead ofassertfor payload comparison to maintain consistency and ensure that the test fails immediately if the payloads do not match.
227-230: The replacement ofassertwithrequirefor error handling in tests is consistent with best practices, ensuring immediate failure upon encountering an error. This enhances the robustness of the test suite.tcp/client/conn.go (1)
169-169: Usingerrors.Newfor static error messages, as done here, is a good practice for consistency and clarity in error handling.message/option.go (2)
115-115: Replacingfmt.Errorfwitherrors.Newfor static error messages, as done here, aligns with Go's best practices for error handling.
236-236: Usingerrors.Newfor static error messages, as done here, is consistent with Go's best practices for error handling.udp/server_test.go (2)
200-200: The change from a length check torequire.NotEmptyfor thegotvariable in theTestServerDiscoverfunction is a positive improvement. It makes the intention of the test clearer and leverages therequirepackage's functionality for more expressive tests.
197-203: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-250]
Overall, the test suite in
udp/server_test.gois well-structured and follows good practices in Go testing, including the use ofrequirefor assertions and proper resource cleanup. The change to userequire.NotEmptyenhances the clarity of the test's intention. Keep up the good work!net/connUDP.go (4)
248-248: The use oferrors.Newfor creating error messages without formatting is a good practice for consistency and performance.
398-398: Usingerrors.Newfor simple error messages is appropriate and aligns with Go best practices.
472-472: The transition toerrors.Newfor creating error messages is correctly applied here, enhancing error handling consistency.
611-611: Correctly usingerrors.Newfor error creation without formatting parameters. This change improves the readability and performance of error handling.udp/client_test.go (11)
108-108: Replacingassert.Truewithrequire.Equalfor checking message types enhances test clarity and failure handling.
116-116: Usingassert.Equalfor message type comparison is more direct and readable than the previous approach.
124-124: Correctly usingassert.NotEqualfor message type assertion improves the specificity of the test.
134-134: Switching torequire.Equalfor message type checks in tests ensures immediate failure on mismatch, which is a good practice.
210-210: The use ofassert.Equalfor message type assertion in a separate message test case is appropriate and improves test accuracy.
342-342: Usingassert.Equalfor message type checks in test cases is a good practice for ensuring the expected behavior.
356-356: Correctly usingassert.Equalfor message type assertion in test cases improves the clarity and accuracy of the tests.
472-472: The use ofassert.Equalfor asserting message types in test cases is appropriate and enhances test clarity.
486-486: Applyingassert.Equalfor message type checks in test cases ensures that the tests are specific and clear.
585-585: Usingassert.Equalfor message type assertion in delete operation tests is a good practice for ensuring the expected behavior.
593-593: Correctly usingassert.Equalfor message type checks in test cases improves the clarity and accuracy of the tests.tcp/client_test.go (1)
840-840: The change fromrequire.Truetorequire.ErrorIsfor the error assertion enhances the test's specificity and robustness by ensuring the exact error is checked. This aligns well with the PR's objective of improving error handling.net/blockwise/blockwise_test.go (3)
305-305: Changing fromassert.Errortorequire.Errorfor error assertions ensures that tests fail immediately upon encountering an error, aligning with the PR's objective to enhance testing methodologies.
309-309: Changing fromrequire.Lentorequire.NotEmptyfor cache length checks focuses the assertion on the essential aspect of non-emptiness, which is more relevant to the test's objectives and enhances flexibility.
311-311: Consistently changing fromrequire.Lentorequire.NotEmptyfor cache length checks across different parts of the file enhances the focus on the essential aspect of non-emptiness, aligning with the PR's objectives.dtls/client_test.go (1)
211-211: The error handling in theTestConnGetSeparateMessagefunction has been changed fromasserttorequire, ensuring that the test fails immediately if an unexpected message is received. This change improves the robustness of the test by halting execution on failure, which is especially important in asynchronous or network-dependent tests where continued execution after a failure could lead to misleading results or further errors.udp/client/conn_test.go (2)
377-377: The error handling in theTestConnGetSeparateMessagefunction has been changed fromasserttorequire, ensuring that the test fails immediately if an unexpected message is received. This change improves the robustness of the test by halting execution on failure, which is especially important in asynchronous or network-dependent tests where continued execution after a failure could lead to misleading results or further errors.
1006-1006: The change fromrequire.Truetorequire.ErrorIsfor error comparison in theTestConnRequestMonitorDropRequestfunction is a significant improvement. It allows for more precise error handling by verifying that the error is exactly what is expected, rather than just checking for the presence of an error. This makes the test more accurate and reliable.net/blockwise/blockwise.go (9)
207-207: The use oferrors.Newfor creating error messages without formatting is appropriate and improves the consistency of error handling in the codebase.
210-210: The use oferrors.Newfor creating error messages without formatting is appropriate and improves the consistency of error handling in the codebase.
219-219: The use oferrors.Newfor creating error messages without formatting is appropriate and improves the consistency of error handling in the codebase.
586-586: The use oferrors.Newfor creating error messages without formatting is appropriate and improves the consistency of error handling in the codebase.
597-597: The use oferrors.Newfor creating error messages without formatting is appropriate and improves the consistency of error handling in the codebase.
761-761: The use oferrors.Newfor creating error messages without formatting is appropriate and improves the consistency of error handling in the codebase.
719-719: The use oferrors.Newfor creating error messages without formatting is appropriate and improves the consistency of error handling in the codebase.
666-666: Consider handling the error frompayloadFile.Truncate(payloadSize)immediately after its occurrence to ensure that any issues with truncating the file are caught and handled appropriately.
207-210: Overall, the replacement offmt.Errorfwitherrors.Newacross various error handling scenarios innet/blockwise/blockwise.gois a positive change that standardizes error creation using theerrorspackage. This aligns well with the PR's objectives of enhancing error handling consistency. No further issues were identified in the segments provided. The rest of the file should be reviewed with the same level of detail to ensure consistency and quality throughout.Also applies to: 219-219, 586-586, 597-597, 761-761, 719-719
udp/client/conn.go (5)
326-326: The replacement offmt.Errorfwitherrors.Newfor the error message related to token validation is appropriate since the error message does not require formatting. This change aligns with best practices for generating static error messages.
945-945: The replacement offmt.Errorfwitherrors.Newfor the error message related to multicast message confirmability is correct, as the error message is static and does not require formatting parameters. This is a good practice for creating more efficient and readable error handling.
326-326: Consider adding more specific error messages to enhance debugging and error tracing capabilities. Whileerrors.New("invalid token")is clear, it might be beneficial to include why the token is considered invalid if possible.
945-945: For multicast messages, the error messageerrors.New("multicast messages cannot be confirmable")is clear and informative. However, consider documenting this constraint in the function's comments to improve code readability and maintainability.
323-329: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-949]
Overall, the file demonstrates good adherence to Go best practices, including proper error handling, use of atomic operations for concurrency safety, and clear separation of concerns. However, consider the following suggestions to further improve the code:
- Error Handling Consistency: Ensure that all error messages are consistently informative across the entire file. This aids in debugging and maintenance.
- Documentation: Adding comments to public types and functions would enhance code readability and maintainability, especially for complex logic or when specific behavior is not immediately obvious from the code itself.
- Performance Considerations: For functions that are called frequently or are critical to the application's performance, evaluate the potential impact of operations within them. For example, the use of locks and atomic operations should be justified by the need for concurrency safety, and their performance impact should be considered.
Direct: github.com/pion/dtls/v2 v2.2.8-0.20240327211025-8244c4570c01 github.com/pion/transport/v3 v3.0.2 golang.org/x/exp v0.0.0-20240325151524-a685a6edb6d8 golang.org/x/net v0.22.0 Indirect: golang.org/x/crypto v0.21.0 golang.org/x/sys v0.18.0
Danielius1922
force-pushed
the
adam/feature/update-deps
branch
from
923bce5
to
22afe59
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum
Files selected for processing (40)
- .golangci.yml (5 hunks)
- dtls/client_test.go (1 hunks)
- dtls/server/server.go (2 hunks)
- dtls/server/session.go (2 hunks)
- message/codes/code_string.go (2 hunks)
- message/codes/codes.go (2 hunks)
- message/codes/codes_test.go (1 hunks)
- message/option.go (3 hunks)
- message/options_test.go (2 hunks)
- message/pool/message_test.go (2 hunks)
- message/status/status_test.go (3 hunks)
- mux/router.go (1 hunks)
- mux/router_test.go (1 hunks)
- net/blockwise/blockwise.go (9 hunks)
- net/blockwise/blockwise_test.go (7 hunks)
- net/client/limitParallelRequests/limitParallelRequests_test.go (2 hunks)
- net/connUDP.go (6 hunks)
- net/connUDP_internal_test.go (3 hunks)
- net/conn_test.go (3 hunks)
- net/dtlslistener.go (1 hunks)
- net/observation/handler.go (4 hunks)
- net/tlslistener_test.go (4 hunks)
- pkg/cache/cache_test.go (2 hunks)
- pkg/sync/map.go (1 hunks)
- server.go (2 hunks)
- tcp/client/conn.go (1 hunks)
- tcp/client/session.go (2 hunks)
- tcp/client_test.go (1 hunks)
- tcp/coder/bench_test.go (1 hunks)
- tcp/coder/coder_test.go (1 hunks)
- tcp/server/server.go (2 hunks)
- udp/client/conn.go (2 hunks)
- udp/client/conn_test.go (3 hunks)
- udp/client_test.go (11 hunks)
- udp/coder/bench_test.go (1 hunks)
- udp/coder/coder_test.go (1 hunks)
- udp/server/discover.go (3 hunks)
- udp/server/server.go (4 hunks)
- udp/server/session.go (2 hunks)
- udp/server_test.go (1 hunks)
Files skipped from review as they are similar to previous changes (39)
- .golangci.yml
- dtls/client_test.go
- dtls/server/server.go
- dtls/server/session.go
- message/codes/code_string.go
- message/codes/codes.go
- message/codes/codes_test.go
- message/option.go
- message/options_test.go
- message/pool/message_test.go
- message/status/status_test.go
- mux/router.go
- mux/router_test.go
- net/blockwise/blockwise.go
- net/blockwise/blockwise_test.go
- net/client/limitParallelRequests/limitParallelRequests_test.go
- net/connUDP.go
- net/connUDP_internal_test.go
- net/conn_test.go
- net/dtlslistener.go
- net/observation/handler.go
- pkg/cache/cache_test.go
- pkg/sync/map.go
- server.go
- tcp/client/conn.go
- tcp/client/session.go
- tcp/client_test.go
- tcp/coder/bench_test.go
- tcp/coder/coder_test.go
- tcp/server/server.go
- udp/client/conn.go
- udp/client/conn_test.go
- udp/client_test.go
- udp/coder/bench_test.go
- udp/coder/coder_test.go
- udp/server/discover.go
- udp/server/server.go
- udp/server/session.go
- udp/server_test.go
Additional comments not posted (1)
net/tlslistener_test.go (1)
78-78: The replacement ofassertwithrequirein test assertions is a positive change, ensuring that tests fail immediately on error, which aligns with the PR's objectives to enhance error handling and testing methodologies. This change improves test reliability by enforcing critical error handling.Also applies to: 81-81, 89-89, 112-112, 115-115, 123-123, 128-128, 130-130, 164-164, 167-167, 175-175, 213-213, 220-220, 223-223
Danielius1922
force-pushed
the
adam/feature/update-deps
branch
from
22afe59
to
5f64797
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #545 +/- ##
==========================================
+ Coverage 75.81% 75.86% +0.05%
==========================================
Files 72 72
Lines 5945 5941 -4
==========================================
Hits 4507 4507
+ Misses 1044 1042 -2
+ Partials 394 392 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Actionable comments posted: 1
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum
Files selected for processing (40)
- .golangci.yml (5 hunks)
- dtls/client_test.go (1 hunks)
- dtls/server/server.go (2 hunks)
- dtls/server/session.go (2 hunks)
- message/codes/code_string.go (2 hunks)
- message/codes/codes.go (2 hunks)
- message/codes/codes_test.go (1 hunks)
- message/option.go (3 hunks)
- message/options_test.go (2 hunks)
- message/pool/message_test.go (2 hunks)
- message/status/status_test.go (3 hunks)
- mux/router.go (1 hunks)
- mux/router_test.go (1 hunks)
- net/blockwise/blockwise.go (9 hunks)
- net/blockwise/blockwise_test.go (7 hunks)
- net/client/limitParallelRequests/limitParallelRequests_test.go (2 hunks)
- net/connUDP.go (6 hunks)
- net/connUDP_internal_test.go (3 hunks)
- net/conn_test.go (3 hunks)
- net/dtlslistener.go (1 hunks)
- net/observation/handler.go (4 hunks)
- net/tlslistener_test.go (4 hunks)
- pkg/cache/cache_test.go (2 hunks)
- pkg/sync/map.go (1 hunks)
- server.go (2 hunks)
- tcp/client/conn.go (1 hunks)
- tcp/client/session.go (2 hunks)
- tcp/client_test.go (1 hunks)
- tcp/coder/bench_test.go (1 hunks)
- tcp/coder/coder_test.go (1 hunks)
- tcp/server/server.go (2 hunks)
- udp/client/conn.go (2 hunks)
- udp/client/conn_test.go (3 hunks)
- udp/client_test.go (11 hunks)
- udp/coder/bench_test.go (1 hunks)
- udp/coder/coder_test.go (1 hunks)
- udp/server/discover.go (3 hunks)
- udp/server/server.go (4 hunks)
- udp/server/session.go (2 hunks)
- udp/server_test.go (1 hunks)
Files skipped from review as they are similar to previous changes (39)
- .golangci.yml
- dtls/client_test.go
- dtls/server/server.go
- dtls/server/session.go
- message/codes/code_string.go
- message/codes/codes.go
- message/codes/codes_test.go
- message/option.go
- message/options_test.go
- message/pool/message_test.go
- message/status/status_test.go
- mux/router.go
- mux/router_test.go
- net/blockwise/blockwise.go
- net/blockwise/blockwise_test.go
- net/client/limitParallelRequests/limitParallelRequests_test.go
- net/connUDP.go
- net/connUDP_internal_test.go
- net/conn_test.go
- net/dtlslistener.go
- net/observation/handler.go
- pkg/cache/cache_test.go
- pkg/sync/map.go
- server.go
- tcp/client/conn.go
- tcp/client/session.go
- tcp/client_test.go
- tcp/coder/bench_test.go
- tcp/coder/coder_test.go
- tcp/server/server.go
- udp/client/conn.go
- udp/client/conn_test.go
- udp/client_test.go
- udp/coder/bench_test.go
- udp/coder/coder_test.go
- udp/server/discover.go
- udp/server/server.go
- udp/server/session.go
- udp/server_test.go
Additional comments not posted (2)
net/tlslistener_test.go (2)
109-133: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [78-130]
The replacement of
assertwithrequirefor error handling in tests is a good practice to ensure immediate test failure on critical errors.
161-178: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [164-223]
The replacement of
assertwithrequirein this test function is consistent with the PR's objective to improve error handling in tests.
Summary by CodeRabbit
New Features
errors.Newfor error creation across various components for improved error handling consistency.atomic.Pointer[context.Context]for enhanced performance and safety.Refactor
fmt.Errorfwitherrors.Newin multiple places to standardize error creation.mapspackage to a non-experimental one in router components.Bug Fixes
require.Equal,require.NoError,require.ErrorIs) for better test clarity.Chores
.golangci.ymlfor improved code quality and consistency.