Improve mux errors #495
Merged
Improve mux errors #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… whole applications. Panic is more appropriate than just silently logging.
Danielius1922
approved these changes
Oct 18, 2023
HRogge
added a commit
to HRogge/go-coap
that referenced
this pull request
Oct 26, 2023
* A bad pattern for a handler is a developer error that can often break whole applications. Panic is more appropriate than just silently logging. * Allow user to overwrite mux error handler * Add a warning to HandleFunc about the panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user should be able to use its own error handler for the mux router. In addition to this the mux should not silently log an error if the API user provides a bad path pattern.