Upgrade dependencies #481
Upgrade dependencies #481
Conversation
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
+ Coverage 72.42% 72.54% +0.11%
==========================================
Files 70 71 +1
Lines 5437 5441 +4
==========================================
+ Hits 3938 3947 +9
+ Misses 1106 1104 -2
+ Partials 393 390 -3
|
Danielius1922
force-pushed
the
adam/feature/update-deps
branch
from
a2bceb7
to
06badf4
Compare
go.mod
Outdated
| exclude ( | ||
| // note: github.com/pion/dtls/v2 must be kept at v2.2.8-0.20230828143201-609e5bee6eb0 as long as golang1.18 is supported | ||
| github.com/pion/dtls/v2 v2.2.8-0.20230904031456-60064c6543dd | ||
| // note: github.com/pion/transport/v2 must be kept at v2.2.2 as long as golang1.18 is supported | ||
| github.com/pion/transport/v2 v2.2.3 | ||
| ) |
There was a problem hiding this comment.
Can we avoid this as soon as I get pion/dtls#582 in, which will hopefully be today 👍🏻
There was a problem hiding this comment.
Yes, that would be much better, I wouldn't have to do the excludes then and we can use latest code.
In fact, the current build of plgd/device and plgd/hub is broken since #473 got merged, I forgot to check the compilation of our other repos before it was merged. We were discussing with @jkralik whether to simply not update plgd/device and plgd/hub repos until we drop support for go1.18, but if you can make it compatible that will be the best case scenario.
I can wait, no problem, it's just our convention that I update the repos at the start of a month.
There was a problem hiding this comment.
@Danielius1922 just merged! should be able to update now :)
actions/checkout v3 -> v4
Added to ensure that go 1.18 works until its support is dropped.
Danielius1922
force-pushed
the
adam/feature/update-deps
branch
from
06badf4
to
dd83041
Compare
Submodule: github.com/pion/dtls/v2 v2.2.8-0.20230905141523-2b584af66577 github.com/pion/transport/v3 v3.0.1 golang.org/x/exp v0.0.0-20230817173708-d852ddb80c63 golang.org/x/net v0.14.0 Indirect: golang.org/x/crypto v0.13.0 golang.org/x/sys v0.12.0
Danielius1922
force-pushed
the
adam/feature/update-deps
branch
from
6bc1a18
to
2753dd9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Running tests:
|
|
@hasheddan nicely done, everything works! Thank you for the assist ( or the goal, since you've done more of the work 🥂 ) |
|
Thanks to you as well @Danielius1922! |
No description provided.