Enable data race detection in tests

[Danielius1922]

Summary by CodeRabbit

• New Features

  • Introduced a new variable to conditionally enable race detection in Go tests.

• Bug Fixes

  • Enhanced error message formatting for better clarity and maintainability in the authorization header handling.

[coderabbitai]

Walkthrough

The recent changes involve enhancements in the Makefile and the client/deviceOwnershipBackend.go file. The Makefile now includes a conditional mechanism for race detection in Go tests, allowing for greater flexibility during the build process. In the Go file, error message formatting in a specific function has been improved for better readability and maintainability. These updates aim to optimize both testing configurations and error handling.

Changes

File	Change Summary
Makefile	Introduced TEST_CHECK_RACE for conditional race detection. Updated GO_TEST_ARGS for dynamic configuration and included it in the Docker build command.
client/deviceOwnershipBackend.go	Enhanced error message formatting in TokenFromOutgoingMD for improved clarity and performance.

Poem

🐇 In the land of code where changes bloom,
A race detector thumps like a joyful tune.
With clearer messages, errors take flight,
Our tests grow strong, from morning to night.
Hooray for the tweaks, let’s hop and cheer,
For better builds and messages clear! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.85%. Comparing base (9644c22) to head (67b214d).

Files	Patch %	Lines
client/deviceOwnershipBackend.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   76.85%   76.85%           
=======================================
  Files         121      121           
  Lines        7225     7225           
=======================================
  Hits         5553     5553           
  Misses       1084     1084           
  Partials      588      588           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9644c22 and 67b214d.

Files selected for processing (2)

• Makefile (1 hunks)
• client/deviceOwnershipBackend.go (1 hunks)

Additional comments not posted (3)

client/deviceOwnershipBackend.go (1)

114-114: Improved error message formatting.

The use of fmt.Errorf with formatted strings enhances readability and maintainability. This change is a good practice in Go.

Makefile (2)

18-23: Conditional race detection in tests.

The introduction of TEST_CHECK_RACE and GO_TEST_ARGS allows for dynamic configuration of race detection in Go tests. This enhances the flexibility and robustness of the testing process.

---

30-30: Inclusion of GO_TEST_ARGS in Docker build.

Passing GO_TEST_ARGS as a build argument in the Docker image build process ensures that race detection can be configured for tests run within Docker. This is a useful enhancement for consistent testing environments.