Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "Main page caching doesn't work properly" #192

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

SunPj
Copy link
Contributor

@SunPj SunPj commented Feb 12, 2024

Last-Modified HTTP header of assets contained in jar is wrong

See playframework/playframework#10572

Last-Modified HTTP header of assets contained in jar is wrong

See playframework/playframework#10572
@mkurz
Copy link
Member

mkurz commented Feb 21, 2024

This makes sense.
@SunPj do you make actual use of this repo here actually?

@mkurz mkurz merged commit 8f84b2a into playframework:main Feb 21, 2024
3 of 5 checks passed
@SunPj
Copy link
Contributor Author

SunPj commented Feb 22, 2024

@mkurz Yes I use it

@mkurz
Copy link
Member

mkurz commented Feb 22, 2024

@SunPj are there any other problems with this seed project? Would you be interested in becoming a maintainer of it? So you can merge pull requests, push commits etc. to keep this seed project up to date, also of course you can enhance it.
What do you think?

@SunPj
Copy link
Contributor Author

SunPj commented Feb 22, 2024

@mkurz Thanks for offering this to me, I am afraid I won't have enough time, but we can try

@mkurz
Copy link
Member

mkurz commented Feb 22, 2024

@SunPj I added you as maintainer to this repo right now, you need to accept the inviation.

@SunPj
Copy link
Contributor Author

SunPj commented Feb 22, 2024

Thanks @mkurz I have just accepted your invitation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants