Resolve animation nodes correctly and uniquify sibling node names #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also appears to fix playcanvas/model-viewer#133 |
ellthompson
approved these changes
Dec 9, 2021
mvaligursky
reviewed
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #playcanvas/model-viewer#135
We've had a bug in the gltf loader which prepends the name of the first node in the file to the animation path. This results in totally incorrect animation paths when the root node is not first in the list.
We are also unable to resolve paths in the tree when sibling nodes have the same name.
This PR does the following:
This PR appears to resolve a number of existing problem gltf files.