Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add size-limit #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: add size-limit #40

wants to merge 1 commit into from

Conversation

yordis
Copy link

@yordis yordis commented Jul 16, 2022

Description

Add https://github.com/ai/size-limit to later add the CI integration.

IMPORTANT: because of how the Github Action for size-limit works, you need to merge the dependencies and configure the CI first. The Action will clone the master version to compare the before and after, so the plugins must be available since the Action doesn't install the plugins for you. Then we could merge #41

Here is how it would look like: yordis#1

Screenshots or GIFs (if appropriate):

Screen Shot 2022-07-16 at 5 33 59 PM

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [10, 12, 14]
node: [14, 16, 18]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had an issue installing the dependencies since 10 and 12 reached their EOL if I am not mistaken https://nodejs.org/en/about/releases/

@yordis yordis mentioned this pull request Jul 16, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant