Skip to content

try looking deeper into the socket to see if still connected #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ruslandoga wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

try looking deeper into the socket to see if still connected #249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f52d4dc
try looking deeper into the socket to see if still connected
ruslandoga Mar 12, 2025
9334855
add todo
ruslandoga Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion lib/ch/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ defmodule Ch.Connection do
# reconnect once. If the re-connect failed, return the old
# connection and let the error bubble up to the caller.
defp maybe_reconnect(conn) do
if HTTP.open?(conn) do
if HTTP.open?(conn) and internal_open?(conn.socket) do
conn
else
opts = HTTP.get_private(conn, :connect_options)
Expand All @@ -412,6 +412,26 @@ defmodule Ch.Connection do
end
end

require Record
Record.defrecordp(:sslsocket, Record.extract(:sslsocket, from_lib: "ssl/src/ssl_api.hrl"))

# TODO :socket
@spec internal_open?(:gen_tcp.socket() | :ssl.sslsocket()) :: boolean
defp internal_open?(socket) do
peername_result =
case socket do
# plain
_ when is_port(socket) -> :inet.peername(socket)
# ssl
sslsocket() -> :ssl.peername(socket)
end

case peername_result do
{:ok, {_host, _port}} -> true
{:error, reason} when reason in [:einval, :enotconn] -> false
end
end

defp do_connect(opts) do
scheme = String.to_existing_atom(opts[:scheme] || "http")
address = opts[:hostname] || "localhost"
Expand Down