New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure header menu user is tabbable and interactive #3425

Closed

ktunprasert wants to merge 1 commit into plausible:master from ktunprasert:master

ktunprasert commented Oct 14, 2023

Changes

Ensures the header menu "user" can be highlighted by the tabindex HTML attribute
Add role="button" attribute to help with accessibility tools
Add aria-label to describe what the button task is

Tests

Automated tests have been added
This PR does not require tests

Changelog

Entry has been added to changelog
This PR does not make a user-facing change

Documentation

Docs have been updated
This change does not need a documentation update

Dark mode

The UI has been tested both in dark and light mode
This PR does not change the UI


          Ensure header menu user is tabbable and interactive

33ec7a8

Author

ktunprasert commented Oct 27, 2023

Closed as this seem to have been fixed :) thank you devs

ktunprasert closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet