feat: implementation of links to tutorials#548
Draft
rudilp28 wants to merge 3 commits intoplatiagro:developfrom
Draft
feat: implementation of links to tutorials#548rudilp28 wants to merge 3 commits intoplatiagro:developfrom
rudilp28 wants to merge 3 commits intoplatiagro:developfrom
Conversation
LuanEdCosta
suggested changes
Feb 3, 2022
Contributor
LuanEdCosta
left a comment
LuanEdCosta
left a comment
There was a problem hiding this comment.
Prototype
Implemented
Ant Design doesn't have the icon used on the prototype, so you don't need to change the icon, but you should align the tutorial link icon at the end of the draggable item.
LuanEdCosta
suggested changes
Feb 4, 2022
|
|
||
| .icon-url { | ||
| position: absolute; | ||
| left: 220px; |
Contributor
There was a problem hiding this comment.
Avoid fixing the position like this, because it is a bad practice. Try to use the margin-left CSS property to align the icon on the right.
LuanEdCosta
previously approved these changes
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added links to platform tutorials, so tasks have an explanatory tutorial.
Added icon fron AntDesign.