WIP: Project:create --template and --initialize flags#829
Closed
shawnawsu wants to merge 3 commits intoplatformsh:developmentfrom
Closed
WIP: Project:create --template and --initialize flags#829shawnawsu wants to merge 3 commits intoplatformsh:developmentfrom
shawnawsu wants to merge 3 commits intoplatformsh:developmentfrom
Conversation
bbujisic
suggested changes
Aug 30, 2019
|
|
||
| $subscription = $this->api()->getClient() | ||
| ->createSubscription( | ||
| $options['catalog'], |
Contributor
There was a problem hiding this comment.
Push to the back of the arg list.
Author
|
We're moving forward with #831 so this can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress needs additional testing for edge cases and proper error handling. Initial work to achieve:
Adding a --template arg to project:create that would pass a template URL to the options_url parameter of the subscription
If no template is provided, using the /setup/catalog API on Accounts to fetch a catalog file and allow the user to pick a template from the CLI
Adding a --initialize flag to project:create that would execute the initialization of your project for you from the project_options.initialize key, as Console does, if you supplied a template
This relies on updates to the client php library.