Variants directory for custom platform #245
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scripts will search for the "variants_dir" directory specified in custom board ".json" file in: - project root directory - core_dir - framework installed "variants"
…son variants_dir attribute.
Member
|
Thanks for the PR, I appreciate the effort. However, I don’t think these changes belong in this repository. We never planned to store variant files within the platform. It might make more sense to handle that in your dedicated fork, so this new functionality should be added there. |
Contributor
Author
|
As you wish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the platform's directory as a possible relative path for
build.variants_dirspecification in a custom board.json