fix(cli): Fixed additionalProperties and recursive $ref resolution#87
Open
charlesbodman wants to merge 1 commit intoplatformatic:mainfrom
Open
fix(cli): Fixed additionalProperties and recursive $ref resolution#87charlesbodman wants to merge 1 commit intoplatformatic:mainfrom
charlesbodman wants to merge 1 commit intoplatformatic:mainfrom
Conversation
… in schema processing - Updated the getType function to use a while loop for resolving $ref references. - Improved handling of additionalProperties to support recursive types and combined properties. - Added tests for various scenarios including additionalProperties with recursive types and multi-level $ref resolution. refactor(openapi-common): streamline additionalProperties handling in writeObjectProperties - Modified writeObjectProperties to handle additionalProperties more effectively, including cases for true and object types. - Introduced new tests to validate the behavior of writeObjectProperties with complex schemas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with additionalProperties type generation
Input OpenAPI Schema:
Before Fix
After Fix
Closes #19