feat: adding netapp-iscsi-helper script#72
Open
sanya-pf9 wants to merge 2 commits into
Open
Conversation
sanya-pf9
requested review from
AnirudhPokala,
poojaghumre,
poojajadhavp9 and
tanaypf9
|
|
||
|
|
||
| def get_server(server_id): | ||
| s = os_cmd("server", "show", server_id) |
Contributor
There was a problem hiding this comment.
if os_cmd returns empty/[] or invalid json, then accessing json object will cause get_server crash. Need to handle that case.
| if matched: | ||
| for s in matched: | ||
| host_iqn_map[s] = {iqn} | ||
| print(f" --host-iqn: {s} → {iqn}", flush=True) |
Contributor
There was a problem hiding this comment.
do we want here to replace existing?? or add to existing?
Collaborator
Author
There was a problem hiding this comment.
Fixed, Now --host-iqn accumulates on top of whatever was inferred
AnirudhPokala
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a failed live migration, OpenStack can leave behind corrupted iSCSI
attachment state on the NetApp array. The VM may still be running, but its
disk is mapped to the wrong igroup — which can cause I/O errors, failed
rescans, or a complete loss of disk access on the next reboot.
This script:
All testing evidence and samples can be found in the READ ME