Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix caching calls to _vector_for_key_cached and _out_of_vocab_vector_cached #47

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix caching calls to _vector_for_key_cached and _out_of_vocab_vector_cached #47

wants to merge 5 commits into from

Commits on Feb 7, 2019

  1. Update __init__.py 

    `_query_is_cached` will always returns false because `_cache.get` expects `key` to be in a tuple. This renders the caching useless.
    @zfang
    zfang committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    c452881 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from zfang/zfang-patch-1 

    Fix _query_is_cached to allow caching
    @zfang
    zfang committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    4b2afc3 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2019

  1. Fix another caching issue with _out_of_vocab_vector_cached

    Felix Fang committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    1043fc1 View commit details
    Browse the repository at this point in the history

  2. Fix calls args and kwargs inconsistencies because lru_cache treats th… 

    …em differently
    Felix Fang committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    25cf26c View commit details
    Browse the repository at this point in the history

  3. Use looked up vectors directly instead of calling query; fix _out_of_… 

    …vocab_vector_cached._cache.get call
    Felix Fang committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    fd5f132 View commit details
    Browse the repository at this point in the history