Auto cell registration + unify table and collection views #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anayini
reviewed
Jan 27, 2018
Sources/CellParentViewProtocol.swift
Outdated
| For `UICollectionViewCell`, this would be `UICollectionView`. | ||
| For `UITableViewCell`, this would be `UITableView`. | ||
| */ | ||
| protocol CellParentViewProtocol { |
There was a problem hiding this comment.
How do you feel about Container versus Parent?
There was a problem hiding this comment.
🤷♂️
either works for me
Ben-G
approved these changes
Jan 28, 2018
Sources/CellParentViewProtocol.swift
Outdated
| For `UICollectionViewCell`, this would be `UICollectionView`. | ||
| For `UITableViewCell`, this would be `UITableView`. | ||
| */ | ||
| protocol CellParentViewProtocol { |
| public protocol ReusableSupplementaryViewProtocol { | ||
|
|
||
| /// The registration info for the supplementary view. | ||
| var viewInfo: SupplementaryViewInfo? { get } // TODO: make this not optional |
There was a problem hiding this comment.
Are you avoiding addressing this TODO now to keep this PR reasonably sized?
There was a problem hiding this comment.
correct. will follow-up
Rather than copy-pasta table view code for collection view, let's unify them. This introduces `CellParentViewProtocol` to reduce duplication in auto-registering cells. It unifies the APIs of tables and collections. On top of this, we add `ReusableCellProtocol` and `ReusableSupplementaryViewProtocol` to unify our cell view models and supplementary view models. Now there's a single API for registering cells automatically. All work based on: https://github.com/jessesquires/JSQDataSourcesKit/blob/develop/Source/ReusableViewConfig.swift Almost completes #18, starts initial work on #46
jessesquires
force-pushed
the
jsq/unify-omfg
branch
from
2465185
to
f6a0e5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than copy-pasta table view code for collection view, let's unify them.
This introduces
CellParentViewProtocolto reduce duplication in auto-registering cells. It unifies the APIs of tables and collections.On top of this, we add
ReusableCellProtocolandReusableSupplementaryViewProtocolto unify our cell view models and supplementary view models.Now there's a single API for registering cells automatically.
All work based on:
https://github.com/jessesquires/JSQDataSourcesKit/blob/develop/Source/ReusableViewConfig.swift
Almost completes #18, starts initial work on #46