Distinguish HA from non-HA SKUs in JSON output#1270
Conversation
The other output formats do this already but the JSON output just duplicated each object. This patch adds the same kind of distinguishing fields that other outputy formats use.
|
This still isn't right, actually. The price on the non-HA SKU is still the price of the HA SKU. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 109152c. Configure here.
| Rate: c.rate, | ||
| Configuration: c.Configuration, | ||
| Replicas: c.Replicas, | ||
| }, "", " ") |
There was a problem hiding this comment.
Non-HA JSON shows HA price
High Severity
JSON marshaling embeds the shared API ClusterSKU (c.orig) while only adding a sibling Rate field. Table and CSV already use formatClusterFields with ReplicaRate for single-node rows, but JSON still surfaces the HA pricing from the embedded SKU, so non-HA entries keep the HA price (as noted in review).
Reviewed by Cursor Bugbot for commit 109152c. Configure here.
There was a problem hiding this comment.
You're wrong. The rate is correct for HA and single-node for all three output formats.
2 participants
The other output formats do this already but the JSON output just duplicated each object.
This patch adds the same kind of distinguishing fields that other outputy formats use.