Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #109

Merged
merged 28 commits into from
Mar 4, 2024
Merged

Bug fixes #109

merged 28 commits into from
Mar 4, 2024

Conversation

thejessewinton
Copy link
Contributor

@thejessewinton thejessewinton commented Mar 3, 2024

Fine tooth comb bug fixes and improvements.

  • Brings back loading skeletons: while we tried to eliminate the need for loading skeletons, given the dynamic nature of the app, loading skeletons have proven to be necessary.
  • Brings optimistic UI upgrades across the app: aside from getting them working on reactions again, there are a number of new spots where we use optimistic UI to instantly load new data; adding and deleting comments, editing and deleting posts, and editing profiles- these actions all take advantage of the great optimistic UI tooling that tRPC offers.

Overall, while this is bringing back some old imperatives, it is a step forward to where Beam needs to be architecturally, and makes sure that the small bugs that have developed and fell through the cracks are fixed.

Copy link

vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beam ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 8:15pm

@thejessewinton thejessewinton marked this pull request as ready for review March 3, 2024 05:18
@thejessewinton thejessewinton marked this pull request as draft March 4, 2024 20:07
auto-merge was automatically disabled March 4, 2024 20:07

Pull request was converted to draft

@thejessewinton thejessewinton merged commit 5be71ab into main Mar 4, 2024
5 checks passed
@thejessewinton thejessewinton deleted the bug-fixes branch March 4, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants