Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: allow multiple values for node-label flag #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morpheu
Copy link

@morpheu morpheu commented Feb 28, 2020

This PR allow pass multiple values for node-label arg. Now when specify node-label on extraArgs it's a list instead string. Eg:

extraArgs:
  node-label:
    - "label1=value1"
    - "label2=value2"

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   85.41%   85.41%           
=======================================
  Files           6        6           
  Lines         288      288           
=======================================
  Hits          246      246           
  Misses         40       40           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a877e7f...2b3d3d0. Read the comment docs.

@jacobstr
Copy link
Contributor

Thanks for this!

I believe existing chart users may be broken here if they used singular node-label: hello=world form. I think we may want to bump the chart version to 0.2.0 since this may affect folks using this chart with an existing values.yaml.

Side node - It might be worth updating the documentation in extraArgs as well (in fact, there's no docs there currently) to mention this behavior / provide hints that it's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants