Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos detected by typos workflow #69

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

weishan18
Copy link
Contributor

@weishan18 weishan18 commented Oct 8, 2024

Resolving issue #68

Description
Commit for #61 introduces typos workflow but it fails with red X mark ❌ . It is because there are some typos in the code base.

Changes
Handle typos detected in https://github.com/planetarium/9c-board/actions/runs/11230002273/job/31216611628?pr=67

Copy link
Contributor

@moreal moreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since GraphQL files you amended, are from planetarium/NineChronicles.Headless service and planetarium/mimir, it shouldn't be updated manually. Could you ignore them by using typos.toml file? I left related links at the issue.

@weishan18
Copy link
Contributor Author

weishan18 commented Oct 8, 2024

Oh, i have misunderstood the requirements then, I'll look into this now. Thanks!

Since GraphQL files you amended, are from planetarium/NineChronicles.Headless service and planetarium/mimir, it shouldn't be updated manually. Could you ignore them by using typos.toml file? I left related links at the issue.

@weishan18 weishan18 force-pushed the fix_typos branch 5 times, most recently from f0ebffa to e2ef09e Compare October 8, 2024 08:10
Ignoring graphql directory as the files are from planetarium/NineChronicles.Headless service and planetarium/mimir, they shouldn't be updated manually.
Copy link
Contributor

@moreal moreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it seems to work!! Thank you!! 🚀

@moreal moreal merged commit afc3897 into planetarium:main Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants