pkp/pkp-lib#10263 Relax editing metadata on published/posted materials #398
Conversation
Hafsa-Naeem
force-pushed
the
relax_edit_metadata
branch
2 times, most recently
from
75270b6 to
435e234
Compare
There was a problem hiding this comment.
The workflow still includes a Vue file called WorkflowPublicationEditDisabled.vue, but with these changes, it's used to present a warning, rather than a prohibition against editing. The filename should be adjusted -- but watch out in case this is also used in the author interface; I didn't check. If it is used there, then "disabled" is still appropriate; it might be necessary to either make a copy for the editor's interface under a different name, or generalize it to either warn or prohibit changes.
Hafsa-Naeem
force-pushed
the
relax_edit_metadata
branch
from
435e234 to
c1715f7
Compare
| @@ -2,7 +2,7 @@ | |||
| <div | |||
| class="bg -mx-5 -mt-5 bg-attention p-5 text-center text-base-normal text-on-dark" | |||
| > | |||
| {{ t('publication.editDisabled') }} | |||
| {{ t('publication.editorEditWarning') }} | |||
There was a problem hiding this comment.
I think this change is accidental -- it should still be editDisabled for this file.
| @@ -930,7 +930,7 @@ export const PublicationConfig = { | |||
| formName: 'identifier', | |||
| submission, | |||
| publication: selectedPublication, | |||
| canEdit: permissions.canEditPublication, | |||
| canEdit: 'true', | |||
There was a problem hiding this comment.
This is getting hard-wired true, but there are lots of other references to canEdit in this file that still use permissions.canEditPublication (and that property still appears to be getting supplied). Is this change necessary?
… on published/posted materials
…published/posted materials
…d fixed canEdit.
Hafsa-Naeem
force-pushed
the
relax_edit_metadata
branch
from
c1715f7 to
f296985
Compare
fixes #10263