-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Web of Science Reviewer Recognition Service plugin for OJS 3.4 #301
Conversation
Hi PKP team, can we please get this PR reviewed? |
Hi @bozana , we've made the requested updates and updated the PR, can you please re-review?
^ I've used the same certification type that we were given when published the plugin previously, under Publons name. I have updated it to "reviewed" as you suggested. |
Hi @Alex-nz,
And finally, let me double check regarding the certification level with the team... Thanks a lot! |
I have forgotten to include @v0k1c into my comment above :-( Sorry! But now... :-) |
Hi @bozana! I've just double checked, and Open Sans (although available within the theme plugin?) is not loaded by default? All I'm seeing that is loaded is Noto Sans and Fontawesome. Would it be safe to import/enable it through theme plugin, or what is the preferred way to use additional fonts that are available there? Asking because I can't find anything related to this within the available documentation. #edit - adding @Alex-nz to the reply.. |
Hi @Alex-nz and @v0k1c, I will take a new look at the code, and will forward your question about the fonts to @jardakotesovec :-) |
Hi @Alex-nz and @v0k1c, the code now looks good, no further comments :-) |
@bozana , @jardakotesovec, could we please get the direction for how to proceed with fonts here? We have customers waiting to start using the plugin. |
@v0k1c My understanding is that this plugin renders UI only on editorial side of OJS, after reviewer completes the review, right? On Editorial site we use noto-sans, I would recommend just to use that, so we don't increase the resources that needs to be fetched unnecessarily. Themes utilise various fonts, but these are specific only for 'reader side'. On editorial side we don't intend provide flexibility on theming or use of different fonts. Does that answer the question? |
thanks @jardakotesovec , yes, you have answered the question. |
Thanks a lot all! Merged 🎉 |
Great, thank you very much everyone involved! |
@bozana can you please confirm when is this plugin going to be available within the gallery? I have a local installation of OJS 3.4.0.4 which I used for testing the plugin, but I don't see it in the plugin gallery list. |
Hi @Alex-nz, I can see it now in my local 3.4 installation... Do you see it now? |
@bozana Yes, I can see it today, but for some reason it wasn't present there yesterday. Anyways, it's all good then, thank you. |
Hi @Alex-nz and @v0k1c, may I ask you here a question -- I cannot find anything online: |
hi @bozana, sorry for a delayed response: I was on vacation and only returned today. I've emailed you. |
Thanks a lot @Alex-nz! |
Add Web of Science Reviewer Recognition Service plugin for OJS 3.4 into the plugin gallery. This plugin is the heavily rebranded old Publons plugin, hence I put these together in the file.