Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds first release of DOI For Translation Plugin to the Plugin Gallery #298

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

YvesLepidus
Copy link

This plugin allows to create a copy of a submission, where this new submission represents a translation of the original in a certain language. In addition, it will send Crossref the hasTranslation/isTranslationOf relationship linking the DOI of the original language with the DOI of the submission that is a translation.

@asmecher
Copy link
Member

Thanks, passed along to @ewhanson for review!

@ewhanson
Copy link

ewhanson commented Jul 30, 2024

Looks good to me! 👍 I did see one minor I'll include below, but I don't think it should be blocking to the plugin's inclusion in the plugin gallery.

Adding the plugin-specific CSS happens every time the plugin is registered, regardless of whether it's enabled or not. It should probably be included in the if statement above where the hooks are registered, but I don't think this will cause any problems in practice as the amount of CSS added is so small.

@diegoabadan
Copy link

Thanks, @ewhanson !
We'll fix it to load the CSS only when the plugin is active. Even though it's not blocking, we can fix it tomorrow.

@YvesLepidus
Copy link
Author

Thanks for the review, @ewhanson !
We've changed the plugin so that the CSS is only loaded when the plugin is enabled.

@ewhanson
Copy link

ewhanson commented Aug 1, 2024

Perfect, thanks @YvesLepidus! @asmecher, this is good to go from my end.

@asmecher asmecher merged commit 9661ef1 into pkp:main Aug 9, 2024
1 check passed
@asmecher
Copy link
Member

asmecher commented Aug 9, 2024

Merged -- thanks, @YvesLepidus and @ewhanson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants