Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/main/i6328 improved localization #7336

Merged
merged 20 commits into from
Feb 18, 2022
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8f9d32a
pkp/pkp-lib#6328 Updated localization framework
jonasraoni Sep 12, 2021
d4c4f71
pkp/pkp-lib#6328 Updated usage of Locale
jonasraoni Sep 25, 2021
1499ea1
pkp/pkp-lib#6328 Removed requireComponents
jonasraoni Aug 14, 2021
9d458af
pkp/pkp-lib#6328 Introduced functions in place of named constants for…
jonasraoni Oct 13, 2021
b3664d2
pkp/pkp-lib#6328 Moved the PKPXMLParser::_getStream() method to the F…
jonasraoni Oct 13, 2021
4c37b31
pkp/pkp-lib#6328 Updated the VersionCheck to use SimpleXMLElement (si…
jonasraoni Oct 13, 2021
2844779
pkp/pkp-lib#6328 Added field to configure the time zone in the instal…
jonasraoni Oct 24, 2021
773c416
pkp/pkp-lib#6328 Added pluralization support for the Smarty templates…
jonasraoni Oct 24, 2021
7bb51ec
pkp/pkp-lib#6328 Fixed the "SESSION_DISABLE_INIT" by not initializing…
jonasraoni Oct 25, 2021
74fb5e2
pkp/pkp-lib#6328 Removed client encoding and references to LATIN1/ISO…
jonasraoni Nov 14, 2021
19e1b91
pkp/pkp-lib#6328 Removed method getAllLocales
jonasraoni Nov 15, 2021
be35521
pkp/pkp-lib#6328 Moved IsoCodesFactory to the Locale
jonasraoni Nov 25, 2021
a320d65
pkp/pkp-lib#6328 Removed locales.xml and unused dtd and xml files
jonasraoni Nov 24, 2021
ebc238d
pkp/pkp-lib#6328 Minor updates
jonasraoni Nov 28, 2021
6cdd1cf
pkp/pkp-lib#6328 Recovered most used methods from PKPLocale class for…
jonasraoni Feb 9, 2022
903706c
pkp/pkp-lib#6328 Recovered constants due to backwards compatibility w…
jonasraoni Feb 10, 2022
4483934
pkp/pkp-lib#6328 Renamed Application::isReady() to isUnderMaintenance
jonasraoni Feb 13, 2022
1a699ab
pkp/pkp-lib#6328 Added description to facade methods
jonasraoni Feb 13, 2022
e750625
pkp/pkp-lib#6328 Updated VersionCheck to not cache virtual paths
jonasraoni Feb 13, 2022
f80c4ad
pkp/pkp-lib#6328 Standardized cache code
jonasraoni Feb 13, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
#6328 Renamed Application::isReady() to isUnderMaintenance
jonasraoni committed Feb 17, 2022
commit 4483934380959ef02519ab42685e9964fdec8e06
2 changes: 1 addition & 1 deletion Support/Jobs/BaseJob.php
Original file line number Diff line number Diff line change
@@ -57,7 +57,7 @@ public function __construct()

protected function defaultConnection(): string
{
if (!Application::isReady()) {
if (Application::isUnderMaintenance()) {
return 'sync';
}

6 changes: 3 additions & 3 deletions classes/core/PKPApplication.inc.php
Original file line number Diff line number Diff line change
@@ -983,11 +983,11 @@ public static function isUpgrading(): bool
}

/**
* Retrieves whether the application is ready (installed and not being upgraded)
* Retrieves whether the application is under maintenance (not installed or being upgraded)
*/
public static function isReady(): bool
public static function isUnderMaintenance(): bool
{
return static::isInstalled() && !static::isUpgrading();
return !static::isInstalled() || static::isUpgrading();
}

/**
2 changes: 1 addition & 1 deletion classes/core/PKPPageRouter.inc.php
Original file line number Diff line number Diff line change
@@ -82,7 +82,7 @@ public function isCacheable($request, $testOnly = false)
if (SessionManager::isDisabled() && !$testOnly) {
return false;
}
if (!Application::isReady()) {
if (Application::isUnderMaintenance()) {
return false;
}
if (!empty($_POST) || Validation::isLoggedIn()) {
2 changes: 1 addition & 1 deletion classes/core/PKPQueueProvider.inc.php
Original file line number Diff line number Diff line change
@@ -29,7 +29,7 @@ public function runJobsAtShutdown(): void
{
$disableRun = Config::getVar('queues', 'disable_jobs_run_at_shutdown', false);

if ($disableRun || !Application::isReady()) {
if ($disableRun || Application::isUnderMaintenance()) {
return;
}

2 changes: 1 addition & 1 deletion plugins/generic/acron/PKPAcronPlugin.inc.php
Original file line number Diff line number Diff line change
@@ -47,7 +47,7 @@ public function register($category, $path, $mainContextId = null)
$success = parent::register($category, $path, $mainContextId);
HookRegistry::register('Installer::postInstall', [&$this, 'callbackPostInstall']);

if (!Application::isReady()) {
if (Application::isUnderMaintenance()) {
return $success;
}
if ($success) {
Original file line number Diff line number Diff line change
@@ -57,7 +57,7 @@ public function __construct()
public function register($category, $path, $mainContextId = null)
{
$success = parent::register($category, $path, $mainContextId);
if (!Application::isReady()) {
if (Application::isUnderMaintenance()) {
return $success;
}
if ($success && $this->getEnabled()) {