Skip to content

pkp/pkp-lib#11125 Fix: Copyediting Stage, Discussion tags do not populate [stable3.5] #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion classes/mail/variables/ContextEmailVariable.php
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ class ContextEmailVariable extends PKPContextEmailVariable
public const CONTEXT_NAME = 'pressName';
public const CONTEXT_URL = 'pressUrl';
public const CONTEXT_SIGNATURE = 'pressSignature';
public const CONTEXT_ACRONYM = 'pressAcronym';
public const CONTEXT_ACRONYM = 'contextAcronym';

/**
* @copydoc Variable::descriptions()
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<?php

/**
* @file classes/migration/upgrade/v3_5_0/I11125_UpdateEmailTemplateVariables.php
*
* Copyright (c) 2025 Simon Fraser University
* Copyright (c) 2025 John Willinsky
* Distributed under the GNU GPL v3. For full terms see the file docs/COPYING.
*
* @class I11125_UpdateEmailTemplateVariables
*
* @brief Migration to update Email Template variable names
*/

namespace APP\migration\upgrade\v3_5_0;

class I11125_UpdateEmailTemplateVariables extends \PKP\migration\upgrade\v3_5_0\I11125_UpdateEmailTemplateVariables
{
public function oldToNewVariablesMap(): array
{
return [
'COPYEDIT_REQUEST' => [
'pressAcronym' => 'contextAcronym',
],
'LAYOUT_REQUEST' => [
'pressAcronym' => 'contextAcronym',
],
];
}
}
1 change: 1 addition & 0 deletions dbscripts/xml/upgrade.xml
Original file line number Diff line number Diff line change
@@ -162,6 +162,7 @@
<migration class="PKP\migration\upgrade\v3_4_0\I7624_StrftimeDeprecation"/>
<migration class="PKP\migration\upgrade\v3_5_0\I11238_PrepareDBForStructuredCitations"/>
<migration class="APP\migration\upgrade\v3_5_0\I11241_MissingDecisionConstantsUpdate"/>
<migration class="APP\migration\upgrade\v3_5_0\I11125_UpdateEmailTemplateVariables"/>
<code function="downloadIPGeoDB"/>
<note file="docs/release-notes/README-3.5.0" />
</upgrade>
3 changes: 0 additions & 3 deletions locale/ar/locale.po
Original file line number Diff line number Diff line change
@@ -1215,9 +1215,6 @@ msgstr ""
msgid "notification.type.editorAssignmentTask"
msgstr ""

msgid "notification.type.copyeditorRequest"
msgstr ""

msgid "notification.type.layouteditorRequest"
msgstr ""

3 changes: 0 additions & 3 deletions locale/bg/locale.po
Original file line number Diff line number Diff line change
@@ -1473,9 +1473,6 @@ msgstr "Читател е направил коментар за „{$title}“.
msgid "notification.type.public"
msgstr "Публични съобщения"

msgid "notification.type.copyeditorRequest"
msgstr "Бяхте помолени да прегледате оформлението за „{$file}“."

msgid "notification.type.layouteditorRequest"
msgstr "Бяхте помолени да прегледате типографията за „{$file}“."

3 changes: 0 additions & 3 deletions locale/ca/locale.po
Original file line number Diff line number Diff line change
@@ -1426,9 +1426,6 @@ msgstr "Avisos públics"
msgid "notification.type.editorAssignmentTask"
msgstr "S'ha enviat una nova monografia a la qual s'ha d'assignar un editor/a."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locale entries need a space between them or the msgid/msgstr pair won't properly work.

msgid "notification.type.copyeditorRequest"
msgstr "Se us ha demanat revisar els continguts per a «{$file}»."

msgid "notification.type.layouteditorRequest"
msgstr "Se us ha demanat revisar la maquetació per a «{$title}»."

3 changes: 0 additions & 3 deletions locale/cs/locale.po
Original file line number Diff line number Diff line change
@@ -1385,9 +1385,6 @@ msgstr "Veřejná oznámení"
msgid "notification.type.editorAssignmentTask"
msgstr "Byl předložen nový rukopis, k němuž je třeba přiřadit editora."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Byl/a jste požádán/a, abyste schválil/a korektury souboru \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr ""
"Byl/a jste požádán/a, abyste schválil/a grafické návrhy titulu \"{$title}\"."
5 changes: 0 additions & 5 deletions locale/da/locale.po
Original file line number Diff line number Diff line change
@@ -1401,11 +1401,6 @@ msgstr "Offentlige meddelelser"
msgid "notification.type.editorAssignmentTask"
msgstr "Der er indsendt en ny monografi, som en redaktør skal tilknyttes."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr ""
"Du er blevet bedt om at gennemgå det tilrettede i forbindelse med "
"\"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr ""
"Du er blevet bedt om at gennemgå layout i forbindelse med \"{$title}\"."
5 changes: 0 additions & 5 deletions locale/de/locale.po
Original file line number Diff line number Diff line change
@@ -1446,11 +1446,6 @@ msgstr ""
"Eine neue Monographie wurde eingereicht. Sie muss noch einem Herausgeber/"
"einer Herausgeberin zugewiesen werden."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr ""
"Sie wurden um die Durchsicht der lektorierten Manuskripte \"{$file}\" "
"gebeten."

msgid "notification.type.layouteditorRequest"
msgstr "Sie wurden um die Durchsicht der Layout-Dateien \"{$title}\" gebeten."

3 changes: 0 additions & 3 deletions locale/el/locale.po
Original file line number Diff line number Diff line change
@@ -1406,9 +1406,6 @@ msgstr ""
"Μία νέα μονογραφία έχει υποβληθεί και έιναι απαραίτητο να ανατεθεί σε έναν "
"επιμελητή."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Έχετε κληθεί να θεωρήσετε την επιμέλεια κειμένων για το \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr ""
"Έχετε κληθεί να θεωρήσετε την επιμέλεια σελιδοποίησης για το \"{$title}\"."
3 changes: 0 additions & 3 deletions locale/en/locale.po
Original file line number Diff line number Diff line change
@@ -1297,9 +1297,6 @@ msgstr "Public Announcements"
msgid "notification.type.editorAssignmentTask"
msgstr "A new monograph has been submitted to which an editor needs to be assigned."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "You have been asked to review copyedits for \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr "You have been asked to review layouts for \"{$title}\"."

3 changes: 0 additions & 3 deletions locale/es/locale.po
Original file line number Diff line number Diff line change
@@ -1421,9 +1421,6 @@ msgstr ""
"Se ha realizado una propuesta de una monografía para la cuál es necesario "
"asignar un Editor."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Le pedimos que revise las correcciones para \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr "Le pedimos que revise la maquetación para \"{$title}\"."

3 changes: 0 additions & 3 deletions locale/fa/locale.po
Original file line number Diff line number Diff line change
@@ -1334,9 +1334,6 @@ msgstr "یک خواننده برای عنوان {$title} نظر ارسال نم
msgid "notification.type.public"
msgstr "اعلانات عمومی"

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "از شما برای بررسی فایل {$file} درخواست شده است."

msgid "notification.type.layouteditorRequest"
msgstr "از شما برای بررسی ویراستاری عنوان \"{$file}\" درخواست شده است."

5 changes: 0 additions & 5 deletions locale/fi/locale.po
Original file line number Diff line number Diff line change
@@ -1405,11 +1405,6 @@ msgstr "Julkiset ilmoitukset"
msgid "notification.type.editorAssignmentTask"
msgstr "Uusi kirja on lähetetty ja sille tulee valita toimittaja."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr ""
"Sinua on pyydetty arvioimaan tiedoston \"{$file}\" teknisesti toimitetut "
"tiedostot."

msgid "notification.type.layouteditorRequest"
msgstr "Sinua on pyydetty arvioimaan nimekkeen \"{$title}\" taitot."

3 changes: 0 additions & 3 deletions locale/fr/locale.po
Original file line number Diff line number Diff line change
@@ -1487,9 +1487,6 @@ msgstr "Événements du site"
msgid "notification.type.public"
msgstr "Annonces publiques"

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "On vous a demandé de réviser les corrections dans « {$file} »."

msgid "notification.type.layouteditorRequest"
msgstr ""
"Vous avez été invité à réviser la mise en page pour le titre « {$title} »."
3 changes: 0 additions & 3 deletions locale/fr_CA/locale.po
Original file line number Diff line number Diff line change
@@ -1418,9 +1418,6 @@ msgstr ""
"Une nouvelle monographie a été soumise. On doit lui assigner un rédacteur en "
"chef."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "On vous a demandé de réviser les corrections dans \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr "On vous a demandé de réviser la mise en page de \"{$title}\"."

5 changes: 0 additions & 5 deletions locale/gd/locale.po
Original file line number Diff line number Diff line change
@@ -1443,11 +1443,6 @@ msgstr "Fiosan-naidheachd poblach"
msgid "notification.type.editorAssignmentTask"
msgstr "Chaidh monograf ùr a chur agus tha e feumach air deasaiche."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr ""
"Chaidh iarraidh ort lèirmheas a dhèanamh air a’ ghrinn-deasachadh a rinneadh "
"air “{$title}”."

msgid "notification.type.layouteditorRequest"
msgstr ""
"Chaidh iarraidh ort lèirmheas a dhèanamh air a’ cho-dhealbhachd aig "
3 changes: 0 additions & 3 deletions locale/gl/locale.po
Original file line number Diff line number Diff line change
@@ -1405,9 +1405,6 @@ msgstr "Anuncios públicos"
msgid "notification.type.editorAssignmentTask"
msgstr "Enviouse unha nova monografía á que hai que asignar un editor/a."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Pedíronche que revises as correccións de \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr "Pedíronche que revises os deseños de \"{$title}\"."

3 changes: 0 additions & 3 deletions locale/hr/locale.po
Original file line number Diff line number Diff line change
@@ -1380,9 +1380,6 @@ msgstr "Javne objave"
msgid "notification.type.editorAssignmentTask"
msgstr "Prijavljena je nova monografija kojoj je potrebno odrediti urednika."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgid "notification.type.copyeditorRequest"
msgstr "Zamoljeni ste da pregledate kopije za \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr "Zamoljeni ste da pregledate izglede za \"{$title}\"."

3 changes: 0 additions & 3 deletions locale/hu/locale.po
Original file line number Diff line number Diff line change
@@ -1429,9 +1429,6 @@ msgstr "Nyilvános értesítések"
msgid "notification.type.editorAssignmentTask"
msgstr "Új kiadványt küldtek be, amelyhez szerkesztőt kell hozzárendelni."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Felkérték a(z) \"{$file}\" olvasószerkesztői átekintésére."

msgid "notification.type.layouteditorRequest"
msgstr "Felkérték a(z) \"{$cím}\" tördelőszerkesztői áttekintésére."

3 changes: 0 additions & 3 deletions locale/id/locale.po
Original file line number Diff line number Diff line change
@@ -1461,9 +1461,6 @@ msgstr "Pengumuman Publik"
msgid "notification.type.editorAssignmentTask"
msgstr "Monograf baru telah diserahkan dan perlu menunjuk editor."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Anda telah diminta untuk meninjau copyedit untuk \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr "Anda telah diminta untuk meninjau tata letak untuk \"{$title}\"."

3 changes: 0 additions & 3 deletions locale/it/locale.po
Original file line number Diff line number Diff line change
@@ -1422,9 +1422,6 @@ msgid "notification.type.editorAssignmentTask"
msgstr ""
"È stata proposta una nuova Monografia, a cui occorre assegnare un editor."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Sei stato sollecitato a fare il copyediting per \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr "Sei stato sollecitato a rivedere il layout per \"{$title}\"."

3 changes: 0 additions & 3 deletions locale/mk/locale.po
Original file line number Diff line number Diff line change
@@ -1421,9 +1421,6 @@ msgstr "Јавни соопштенија"
msgid "notification.type.editorAssignmentTask"
msgstr "Доставена е нова монографија на која треба да и биде доделен уредник."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Од вас е побарано да прегледате копии за „{$file}“."

msgid "notification.type.layouteditorRequest"
msgstr "Од вас е побарано да ги прегледате распоредите за „{$title}“."

3 changes: 0 additions & 3 deletions locale/nb_NO/locale.po
Original file line number Diff line number Diff line change
@@ -1397,9 +1397,6 @@ msgstr "Oppslag"
msgid "notification.type.editorAssignmentTask"
msgstr "En ny monografi har blitt levert inn. Opprett en redaktør for den."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Du har blitt bedt om å se over språvasken av «{$title}»."

msgid "notification.type.layouteditorRequest"
msgstr "Du har blitt bedt om å se over layouten av «{$title}»."

3 changes: 0 additions & 3 deletions locale/pl/locale.po
Original file line number Diff line number Diff line change
@@ -1399,9 +1399,6 @@ msgstr "Ogłoszenia publiczne"
msgid "notification.type.editorAssignmentTask"
msgstr "Zgłoszono nową monografię, do której należy przypisać redaktora."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Zostałeś poproszony o sprawdzenie redakcji \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr "Zostałeś poproszony o recenzję składu \"{$title}\"."

3 changes: 0 additions & 3 deletions locale/pt/locale.po
Original file line number Diff line number Diff line change
@@ -1391,9 +1391,6 @@ msgid "notification.type.editorAssignmentTask"
msgstr ""
"Uma nova monografia foi submetida e necessita de ser designada a um editor."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Foi-lhe solicitado que realize a edição de texto de \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr "Foi-lhe solicitado que reveja o design de \"{$title}\"."

3 changes: 0 additions & 3 deletions locale/pt_BR/locale.po
Original file line number Diff line number Diff line change
@@ -1400,9 +1400,6 @@ msgstr "Notícias Públicas"
msgid "notification.type.editorAssignmentTask"
msgstr "Um editor precisa ser designado à nova monografia submetida."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Solicitação de edição de texto de \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr "Solicitação de revisão dos layouts de \"{$title}\"."

3 changes: 0 additions & 3 deletions locale/ro/locale.po
Original file line number Diff line number Diff line change
@@ -1673,9 +1673,6 @@ msgstr ""
"Această tranzacție este pentru achiziționarea unei descărcări directe a unei "
"singure monografii sau a capitolului unei monografii."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Vă rugăm revizuiți corecturile pentru „{$file}”."

msgid "user.authorization.monographAuthor"
msgstr ""
"Accesul dumneavoastră a fost respins pentru că se pare că nu sunteți autorul "
3 changes: 0 additions & 3 deletions locale/ru/locale.po
Original file line number Diff line number Diff line change
@@ -1418,9 +1418,6 @@ msgstr "Публичные объявления"
msgid "notification.type.editorAssignmentTask"
msgstr "Была отправлена новая книга, которой нужно назначить редактора."

msgid "notification.type.copyeditorRequest"
msgstr "Вас попросили выполнить литературное редактирование для «{$file}»."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.


msgid "notification.type.layouteditorRequest"
msgstr "Вас попросили выполнить верстку для «{$title}»."

3 changes: 0 additions & 3 deletions locale/sl/locale.po
Original file line number Diff line number Diff line change
@@ -1383,9 +1383,6 @@ msgstr ""
"Nova monografska publikacija je bila dodana, ki ji je treba dodeliti "
"urednika."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Prosili so vas za pregled korektur za \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr "Prosili so vas za pregled postavitev za \"{$title}\"."

3 changes: 0 additions & 3 deletions locale/sv/locale.po
Original file line number Diff line number Diff line change
@@ -1281,9 +1281,6 @@ msgstr "Offentliga meddelanden"
msgid "notification.type.editorAssignmentTask"
msgstr "En ny bok har skickats in och behöver tilldelas en redaktör."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

msgstr "Du har ombetts att granska det redigerade manuset för \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr "Du har ombetts att granska layouter för \"{$title}\"."

3 changes: 0 additions & 3 deletions locale/tr/locale.po
Original file line number Diff line number Diff line change
@@ -1395,9 +1395,6 @@ msgstr "Genel Duyurular"
msgid "notification.type.editorAssignmentTask"
msgstr "Bir editörün atanması gereken yeni bir yazı gönderildi."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too.

msgstr "\"{$file}\" için sayfa düzenini gözden geçirmeniz istendi."

msgid "notification.type.layouteditorRequest"
msgstr "“{$title}” için mizanpaj düzenini gözden geçirmeniz istendi."

3 changes: 0 additions & 3 deletions locale/uk/locale.po
Original file line number Diff line number Diff line change
@@ -1400,9 +1400,6 @@ msgstr "Публічні оголошення"
msgid "notification.type.editorAssignmentTask"
msgstr "Було подано нову монографію, для якої потрібно призначити редактора."

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too.

msgstr "Вас попросили виконати літературне редагування \"{$file}\"."

msgid "notification.type.layouteditorRequest"
msgstr "Вас попросили виконати верстання \"{$title}\"."

3 changes: 0 additions & 3 deletions locale/vi/locale.po
Original file line number Diff line number Diff line change
@@ -1207,9 +1207,6 @@ msgstr ""
msgid "notification.type.editorAssignmentTask"
msgstr ""

msgid "notification.type.copyeditorRequest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one 😅

msgstr ""

msgid "notification.type.layouteditorRequest"
msgstr ""