Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OJS][main] #9840 Remove vue3-highlightjs and from highlight.js use only XML language #4275

Closed
wants to merge 1 commit into from
Closed

[OJS][main] #9840 Remove vue3-highlightjs and from highlight.js use only XML language #4275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@
"vue": "^3.3.8",
"vue-chartjs": "^5.2.0",
"vue-draggable-plus": "^0.2.4",
"vue-scrollto": "^2.20.0",
"vue3-highlightjs": "^1.0.5"
"vue-scrollto": "^2.20.0"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its odd that there is no package-lock.json update as part of it. Its important to remove it via npm uninstall to also update package-lock.json. Can you check that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not added the package-lock.json to the commit. I am generally not adding it to the commits when doing such changes. Should I?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@defstat package-lock.json is bit pain when conflict happen. But you want to keep that in sync with package.json

For example if you just remove it from package.json, and someone than runs npm install - it will create update package-lock.json, which is confusing.

And in general package-lock.json purpose is to ensure that everyone, including tests and deployments are all using exactly the same version in their dependencies. So if there is some change in dependencies - package-lock.json should get updated as well.

"devDependencies": {
"@rushstack/eslint-patch": "^1.3.3",
Expand Down
1 change: 0 additions & 1 deletion vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ export default defineConfig(({mode}) => {
'vue-chartjs',
'vue-draggable-plus',
'vue-scrollto',
'vue3-highlightjs',
],
},
build: {
Expand Down
Loading