Implement SonarCloud quality suggestions #159

pkiraly · Dec 8, 2023 · d5e1df7 · d5e1df7
1 parent 0e220bb
commit d5e1df7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/src/main/java/de/gwdg/metadataqa/api/calculator/Indexer.java b/src/main/java/de/gwdg/metadataqa/api/calculator/Indexer.java
@@ -42,9 +42,7 @@ public List<MetricResult> measure(Selector cache) {
           resultMap.put(solrField.getSolrField(), values);
       }
       solrClient.indexMap(recordId, resultMap);
-    } catch (IOException e) {
-      e.printStackTrace();
-    } catch (SolrServerException e) {
+    } catch (IOException | SolrServerException e) {
       e.printStackTrace();
     } catch (Exception e) {
       e.printStackTrace();

diff --git a/src/main/java/de/gwdg/metadataqa/api/configuration/MeasurementConfiguration.java b/src/main/java/de/gwdg/metadataqa/api/configuration/MeasurementConfiguration.java
@@ -7,11 +7,12 @@
 import de.gwdg.metadataqa.api.uniqueness.SolrConfiguration;
 import org.apache.commons.lang3.StringUtils;
 
+import java.io.Serializable;
 import java.util.LinkedHashMap;
 import java.util.Map;
 
-public class MeasurementConfiguration {
-
+public class MeasurementConfiguration implements Serializable {
+  private static final long serialVersionUID = 7754969792852694442L;
   /**
    * Flag whether or not the field extractor is enabled (default: false).
    */

diff --git a/src/main/java/de/gwdg/metadataqa/api/uniqueness/DefaultSolrClient.java b/src/main/java/de/gwdg/metadataqa/api/uniqueness/DefaultSolrClient.java
@@ -183,9 +183,7 @@ public void indexMap(String id, Map<String, List<String>> objectMap) throws IOEx
   public void commit() {
     try {
       solr.commit();
-    } catch (SolrServerException e) {
-      e.printStackTrace();
-    } catch (IOException e) {
+    } catch (SolrServerException | IOException e) {
       e.printStackTrace();
     }
   }
@@ -194,9 +192,7 @@ public void commit() {
   public void deleteAll() {
     try {
       solr.deleteByQuery("*:*");
-    } catch (SolrServerException e) {
-      e.printStackTrace();
-    } catch (IOException e) {
+    } catch (SolrServerException | IOException e) {
       e.printStackTrace();
     }
     commit();