Implement SonarCloud quality suggestions #159

pkiraly · Dec 8, 2023 · 4d8cfe3 · 4d8cfe3
1 parent 4669d9b
commit 4d8cfe3
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 3 deletions.
diff --git a/src/main/java/de/gwdg/metadataqa/api/io/writer/JSONResultWriter.java b/src/main/java/de/gwdg/metadataqa/api/io/writer/JSONResultWriter.java
@@ -41,8 +41,7 @@ private Object getJson(Map<String, List<MetricResult>> result) {
   @Override
   public void writeResult(Map<String, List<MetricResult>> result) throws IOException {
     Object json = getJson(result);
-
-    this.outputWriter.write(json.toString());
+    this.outputWriter.write(json == null ? "" : json.toString());
     this.outputWriter.newLine();
   }
 

diff --git a/src/test/java/de/gwdg/metadataqa/api/configuration/SchemaConfigurationTest.java b/src/test/java/de/gwdg/metadataqa/api/configuration/SchemaConfigurationTest.java
@@ -200,6 +200,20 @@ public void yaml_failureScore() throws FileNotFoundException {
     assertEquals(-1, schema.getPathByLabel("about").getRules().get(0).getFailureScore().intValue());
   }
 
+  @Test
+  public void yaml_naScore() throws FileNotFoundException {
+    Schema schema = ConfigurationReader.readSchemaYaml("src/test/resources/configuration/schema/rules/naScore.yaml").asSchema();
+    assertEquals(-1, schema.getPathByLabel("about").getRules().get(0).getFailureScore().intValue());
+    assertEquals(0, schema.getPathByLabel("about").getRules().get(0).getNaScore().intValue());
+    assertEquals(1, schema.getPathByLabel("about").getRules().get(0).getSuccessScore().intValue());
+  }
+
+  @Test
+  public void yaml_debug() throws FileNotFoundException {
+    Schema schema = ConfigurationReader.readSchemaYaml("src/test/resources/configuration/schema/rules/debug.yaml").asSchema();
+    assertEquals(true, schema.getPathByLabel("about").getRules().get(0).getDebug());
+  }
+
   @Test
   public void yaml_successScore() throws FileNotFoundException {
     Schema schema = ConfigurationReader.readSchemaYaml("src/test/resources/configuration/schema/rules/successScore.yaml").asSchema();

diff --git a/src/test/java/de/gwdg/metadataqa/api/rule/singlefieldchecker/HiddenCheckerTest.java b/src/test/java/de/gwdg/metadataqa/api/rule/singlefieldchecker/HiddenCheckerTest.java
@@ -7,7 +7,6 @@
 import de.gwdg.metadataqa.api.configuration.ConfigurationReader;
 import de.gwdg.metadataqa.api.configuration.MeasurementConfiguration;
 import de.gwdg.metadataqa.api.rule.CheckerTestBase;
-import de.gwdg.metadataqa.api.rule.RuleChecker;
 import de.gwdg.metadataqa.api.schema.CsvAwareSchema;
 import de.gwdg.metadataqa.api.schema.Schema;
 import de.gwdg.metadataqa.api.util.CsvReader;

diff --git a/src/test/resources/configuration/schema/rules/debug.yaml b/src/test/resources/configuration/schema/rules/debug.yaml
@@ -0,0 +1,7 @@
+format: json
+fields:
+  - name: about
+    path:  $.['about']
+    rules:
+      - minCount: 1
+        debug: true
diff --git a/src/test/resources/configuration/schema/rules/naScore.yaml b/src/test/resources/configuration/schema/rules/naScore.yaml
@@ -0,0 +1,9 @@
+format: json
+fields:
+  - name: about
+    path:  $.['about']
+    rules:
+      - minCount: 1
+        failureScore: -1
+        naScore: 0
+        successScore: 1