Cleanup internally shared functions and rearrange tests folder #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghinks
approved these changes
Feb 28, 2021
ghinks
reviewed
Feb 28, 2021
| @@ -25,7 +25,7 @@ module.exports = async function ({ dependents }) { | |||
| const dependentPkgJSON = await github.getPackageJson(dependentPkgInfo.owner, dependentPkgInfo.name) | |||
| debug(`Dependent module: ${dependentPkgInfo.owner}/${dependentPkgInfo.name}`) | |||
|
|
|||
| if (!checkPackageInPackageJSON(parentPkgJSON.name, dependentPkgJSON)) { | |||
| if (!context.checkPackageInPackageJSON(parentPkgJSON.name, dependentPkgJSON)) { | |||
There was a problem hiding this comment.
my only comment so far
The call to applyPatch, which takes place immediately after this check, carries out the same check
if (!context.checkPackageInPackageJSON(module, packageJSON)) {}but with less debug info, maybe just move this extra debug for errors into applyPatch.
There was a problem hiding this comment.
Sounds good - but since we both have a PR open in the similar area - mind if we merge this and then maybe you can do it in yours or maybe we can follow this up with a separate PR after yours is merged?
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just to make things a teeny bit tidier (primarily for myself).