-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wiby result): change result command output and exit codes #74
Conversation
|
||
statuses.push(status) | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I am reading this correctly once we have completed iterating over all the runs and the isAllSuccess is still true.
Then following the methodology below should we return pipelineStatses.SUCCEED and change the final return to pipelineStatses.FAILED ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed this will simplify code a bit, submitted changes
I saw the changes you made in the getOverallStatusForAllRuns, many thanks. Still reviewing. I took the main branch and merged back into your changes and created scoped package @gvhinks/[email protected]. I then created a PR on a dependency test package. The PR's associated action completed once I typed wiby result. I took some screen shots of the actions with DEBUG=wiby:* from an integration point of view its looking good. |
Looks good, aside from what I assume was a typo? |
Co-authored-by: Dominykas Blyžė <[email protected]>
🎉 This PR is included in version 0.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Following #57 (comment) this PR introduces updates to
wiby result
command:debug
package added as dependencydebug
addedwiby test
command enabled programmatically in order to save old outputswiby:test
,wiby:result
, etc)DEBUG=wiby:*
envwiby result
1
64
Related to #57