Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-use existing branches #101

Merged
merged 3 commits into from
Jul 27, 2021
Merged

Re-use existing branches #101

merged 3 commits into from
Jul 27, 2021

Conversation

dominykas
Copy link
Member

@dominykas dominykas commented Jun 28, 2021 •
edited
Loading

Closes #95

Base automatically changed from fix-404 to main July 13, 2021 11:37
@dominykas dominykas force-pushed the reuse-branch branch 3 times, most recently from c769621 to 054550e Compare July 13, 2021 14:00
@dominykas dominykas marked this pull request as ready for review July 13, 2021 14:49
rodion-arr
rodion-arr approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@rodion-arr rodion-arr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghinks
Copy link
Contributor

ghinks commented Jul 19, 2021

As part of simple due diligence I pulled the branch and ran the tests locally. For me I see issues with test/internals/github-integration.js.

I am looking further.

Screen Shot 2021-07-19 at 11 00 03 AM

Screen Shot 2021-07-19 at 10 58 17 AM

@dominykas
Copy link
Member Author

dominykas commented Jul 21, 2021 •
edited
Loading

For me I see issues with test/internals/github-integration.js.

These specific tests need a valid GITHUB_TOKEN exposed. They get skipped if there is no token at all - maybe you had one for some other GH instance?

@dominykas
Copy link
Member Author

@ghinks as these tests are passing for me locally, and also in CI, I'll assume that all is fine and merge this - ping me if you want to dig deeper to see what's going in there?

@dominykas dominykas merged commit bc3bd54 into main Jul 27, 2021
@dominykas dominykas deleted the reuse-branch branch July 27, 2021 12:42
@dominykas
Copy link
Member Author

🎉 This PR is included in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodion-arr rodion-arr rodion-arr approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Existing branch handling
3 participants
@dominykas @ghinks @rodion-arr