Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace libnpm #26

Merged
merged 3 commits into from
Jan 29, 2025
Merged

replace libnpm #26

merged 3 commits into from
Jan 29, 2025

Conversation

bjohansebas
Copy link
Contributor

libnpm is no longer maintained by npm, and in its place, they created pacote. It doesn't introduce any breaking changes, as far as I can tell.

@bjohansebas
Copy link
Contributor Author

All the tests pass 🥳

@wesleytodd
Copy link
Member

Yep, once the waiting period is done we can merge.

wesleytodd
wesleytodd approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this re-request was just a request to merge?

@wesleytodd wesleytodd merged commit a946ee3 into pkgjs:main Jan 29, 2025
7 checks passed
@bjohansebas bjohansebas deleted the replace-libnpm branch January 29, 2025 20:57
@bjohansebas
Copy link
Contributor Author

Yep, since I still can't do it myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleytodd wesleytodd wesleytodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjohansebas @wesleytodd