Tidy

lib/Devel/Cover/Collection.pm

@@ -127,43 +127,30 @@ sub process_module_file ($self) {
   my $modules = do { local $/; <$fh> };
   close $fh or die "Can't close $file: $!";
   my @modules = grep /\S/, grep !/^ *#/, split /\n/, $modules;
-  # say "modules: @modules";
   $self->add_modules(@modules);
 }
 
 sub build_modules ($self) {
   my @command = qw( cpan -Ti );
   push @command, "-f" if $self->force;
-  # my @command = qw( cpan );
-  # $ENV{CPAN_OPTS} = "-i -T";
-  # $ENV{CPAN_OPTS} .= " -f" if $self->force;
   # $self->_set_local_timeout(300);
   my %m;
   for my $module (sort grep !$m{$_}++, $self->modules->@*) {
     say "Building $module";
     my $output = $self->fsys(@command, $module);
     say $output;
-    say "-----------------------------------------------------------xxx";
   }
   $self->_set_local_timeout(0);
 }
 
 sub add_build_dirs ($self) {
-  say "add_build_dirs";
-  say for @{ $self->build_dirs };
-  # say && system "ls -al $_" for "/remote_staging",
-  # map "$_/build", @{$self->cpan_dir};
   my $exists = sub {
-    # say "exists [$_]";
     my $dir   = "/remote_staging/" . (s|.*/||r =~ s/-\d+$/*/r);
     my @files = glob $dir;
-    # say "checking [$dir] -> [@files]";
     @files
   };
   push $self->build_dirs->@*, grep { !$exists->() } grep -d,
     map glob("$_/build/*"), $self->cpan_dir->@*;
-  say "add_build_dirs:";
-  say for @{ $self->build_dirs };
 }
 
 sub run ($self, $build_dir) {
@@ -189,16 +176,12 @@ sub run ($self, $build_dir) {
   }
 
   $output .= "Testing $module in $build_dir\n";
-  # say "\n$line\n$output$line\n"; return;
 
-  # $output .= $self->sys($^X, "-V");
-  $output .= $self->sys("pwd");
   my @cmd;
   if ($self->local) {
     $ENV{DEVEL_COVER_OPTIONS}   = "-ignore,/usr/local/lib/perl5";
     $ENV{DEVEL_COVER_TEST_OPTS} = "-Mblib=" . $self->bin_dir . "/..";
     @cmd = ($^X, $ENV{DEVEL_COVER_TEST_OPTS}, $self->bin_dir . "/cover");
-    say "*****--[@cmd]";
   } else {
     @cmd = ($^X, $self->bin_dir . "/cover");
   }
@@ -229,7 +212,6 @@ sub run_all ($self) {
     },
     $self->build_dirs
   );
-  print "x" x 80, Dumper \@res;
 }
 
 sub write_json ($self, $vars) {
@@ -344,7 +326,8 @@ sub generate_html ($self) {
     $m->{module} = $mod;
     $m->{link} = "/$module/index.html" if $json->{summary}{Total}{total}{total};
 
-    for my $criterion ($vars->{criteria}->%*) {
+    say Dumper $vars;
+    for my $criterion ($vars->{criteria}->@*) {
       my $summary = $json->{summary}{Total}{$criterion};
       # print "summary:", Dumper $summary;
       my $pc = $summary->{percentage};

utils/dc

@@ -336,21 +336,18 @@ recipe_cpancover-docker-module() {
   ((verbose)) && pi "[-$l-] [$dir] [$module]"
   local v=
   ((verbose)) && v=--verbose
-  set -x
   container=$($docker run -d \
     --volume="$dcdir:/dc:ro" \
     --volume="$staging:/remote_staging:ro" \
     --workdir=/dc --rm=false --name="$name" \
     --memory=1g \
     "$docker_image" \
     "$dir/utils/dc" "$l" cpancover-build-module "$module" "$v")
-  set +x
   ((verbose)) && pi "container is $container"
   $docker wait "$name" # >/dev/null
   # shellcheck disable=SC2181
   if [[ $? == 0 ]]; then
     $docker logs "$name"
-    echo "================================================================"
     local_staging="$staging/$name"
     mkdir -p "$local_staging"
     $docker cp "$name:/root/staging" "$local_staging"