Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fixed typos in landing page and some tailwind class extra spaces #273

Conversation

ArshadChowdhury
Copy link
Contributor

@ArshadChowdhury ArshadChowdhury commented Oct 31, 2023

What does this PR do?

Fixes #

Landing page main image dark mode seems have darken too much of the image reduced the dark part there. (Makes it hard to see the image at all)
Typos in the main text of landing page and footer text.
Removed some extra spaces in tailwind classnames.

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Are there environment variables that should be set? - No
  • What are the minimal test data to have? - N/A
  • What is expected (happy path) to have (input and output)? - N/A
  • Any other important info that could help to test that PR - N/A

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

This is my first PR here can really use some feedback from you guys.

@vercel
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
review-app ❌ Failed (Inspect) Oct 31, 2023 11:33am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @ArshadChowdhury 😃,

Thank you for raising the PR. Soon, the owner/maintainers will review it and offer feedback/suggestions.
Meanwhile if you enjoy contributing to the project, please consider giving it a star ⭐.

@github-actions
Copy link

github-actions bot commented Oct 31, 2023

Thank you for following the naming conventions! 🙏

@ArshadChowdhury ArshadChowdhury changed the title fix: Fixed typos in landing page and some tailwind class extra spaces refactor: Fixed typos in landing page and some tailwind class extra spaces Oct 31, 2023
Copy link
Collaborator

@hemantwasthere hemantwasthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hemantwasthere hemantwasthere merged commit fc2c8c8 into piyushgarg-dev:main Oct 31, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants