Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added delete form feature #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

swaraj344
Copy link

What does this PR do?

added delete form feature which takes formId

Fixes #40
Screenshot 2023-10-22 200548

Loom Video: https://www.loom.com/share/b2cf9605e4a147ed9b60c764d755d7a3

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

You can test it from apollo server

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

Thank you for following the naming conventions! 🙏

@swaraj344 swaraj344 changed the title added delete form feature [Feat]: added delete form feature Oct 22, 2023
@swaraj344
Copy link
Author

also Raised PR on front-end side
here is the link piyushgarg-dev/review-app#238

@swaraj344 swaraj344 changed the title [Feat]: added delete form feature Feat: added delete form feature Oct 22, 2023
@swaraj344 swaraj344 changed the title Feat: added delete form feature [Feat]: Added delete form feature Oct 22, 2023
@swaraj344 swaraj344 changed the title [Feat]: Added delete form feature [feat]: Added delete form feature Oct 22, 2023
@swaraj344 swaraj344 changed the title [feat]: Added delete form feature feat: Added delete form feature Oct 22, 2023
@sujayshanbhag
Copy link

Hello Bhai, Piyush bhai explained this feature is not required on YT. I'm closing the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deleting a form feature
3 participants