Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: public-form: Added query to get form by slug #33

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

psworld
Copy link

@psworld psworld commented Oct 8, 2023

What does this PR do?

Fixes #22

  1. Added query getFormBySlug
  2. Made the slug column @unique in prisma schema so that we can filter using .findUnique()

Type of change

  • New feature (non-breaking change which adds functionality)

@github-actions github-actions bot added enhancement New feature or request hacktoberfest Hacktoberfest Accepted Issues hacktoberfest-accepted Hacktoberfest Accepted labels Oct 8, 2023
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Thank you for following the naming conventions! 🙏

@psworld psworld changed the title feat/public-form: Added query to get form by slug feat: public-form: Added query to get form by slug Oct 8, 2023
@psworld
Copy link
Author

psworld commented Oct 8, 2023

@piyushgarg-dev Hello sir,

I hope this is what you wanted. By Public Route do you mean accessible by any domain ? I have read that express server are by default public.

I don't know how to test it from cross-domain, to check if it's publicly available or not ?

If you want more changes please let me know. I will be more than happy to contribute.

@github-actions
Copy link

Hey there, there is a merge conflict, can you take a look?

@github-actions github-actions bot added the 🚨 merge conflict Merge Conflict label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Hacktoberfest Accepted Issues hacktoberfest-accepted Hacktoberfest Accepted 🚨 merge conflict Merge Conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Public Route to fetch the form public data using slug
1 participant